Drop support for GHC 9.0 (#3875)

* fix dodgy macro

* Automatically remove macros for 9.2

* Manual GLASGOW_HASKELL bits

* Remove from CI

* Remove from docs

* Remove from release CI

* fix positions

* Some simplification in ghcide

* Maybe fix

* Maybe this

* WIP

* More

Author: michaelpj

.github/workflows/release.yaml

@@ -30,7 +30,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ghc: ["9.8.1", "9.6.3", "9.4.7", "9.2.8", "9.0.2"]
+        ghc: ["9.8.1", "9.6.3", "9.4.7", "9.2.8"]
         platform: [ { image: "debian:9"
                     , installCmd: "sed -i s/deb.debian.org/archive.debian.org/g /etc/apt/sources.list && sed -i 's|security.debian.org|archive.debian.org/|g' /etc/apt/sources.list && sed -i /-updates/d /etc/apt/sources.list && apt-get update && apt-get install -y"
                     , toolRequirements: "libnuma-dev zlib1g-dev libgmp-dev libgmp10 libssl-dev liblzma-dev libbz2-dev git wget lsb-release software-properties-common gnupg2 apt-transport-https gcc autoconf automake build-essential curl ghc gzip libffi-dev libncurses-dev libncurses5 libtinfo5 patchelf"
@@ -118,15 +118,6 @@ jobs:
         # Perhaps we can migrate *all* unknown linux builds to a uniform
         # image.
         include:
-          - ghc: 9.0.2
-            platform:
-              { image: "rockylinux:8"
-              , installCmd: "yum -y install epel-release && yum install -y --allowerasing"
-              , toolRequirements: "autoconf automake binutils bzip2 coreutils curl elfutils-devel elfutils-libs findutils gcc gcc-c++ git gmp gmp-devel jq lbzip2 make ncurses ncurses-compat-libs ncurses-devel openssh-clients patch perl pxz python3 sqlite sudo wget which xz zlib-devel patchelf"
-              , DISTRO: "Unknown"
-              , ARTIFACT: "x86_64-linux-unknown"
-              , ADD_CABAL_ARGS: "--enable-split-sections"
-              }
           - ghc: 9.2.8
             platform:
               { image: "rockylinux:8"
@@ -222,7 +213,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        ghc: ["9.8.1", "9.6.3", "9.4.7", "9.2.8", "9.0.2"]
+        ghc: ["9.8.1", "9.6.3", "9.4.7", "9.2.8" ]
     steps:
       - uses: docker://arm64v8/ubuntu:focal
         name: Cleanup (aarch64 linux)
@@ -282,7 +273,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ghc: ["9.8.1", "9.6.3", "9.4.7", "9.2.8", "9.0.2"]
+        ghc: ["9.8.1", "9.6.3", "9.4.7", "9.2.8"]
     steps:
       - name: Checkout code
         uses: actions/checkout@v3
@@ -372,7 +363,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        ghc: ["9.8.1", "9.6.3", "9.4.7", "9.2.8", "9.0.2"]
+        ghc: ["9.8.1", "9.6.3", "9.4.7", "9.2.8"]
     steps:
       - name: install windows deps
         shell: pwsh

.github/workflows/supported-ghc-versions.json

@@ -1 +1 @@
-[ "9.8", "9.6", "9.4" , "9.2" , "9.0" ]
+[ "9.8", "9.6", "9.4" , "9.2" ]

docs/support/ghc-version-support.md

@@ -32,7 +32,7 @@ Support status (see the support policy below for more details):
 | 9.2.(5,6)    | [1.9.1.0](https://github.com/haskell/haskell-language-server/releases/tag/1.9.1.0)   | deprecated                                                                  |
 | 9.2.(3,4)    | [1.8.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.8.0.0)   | deprecated                                                                  |
 | 9.2.(1,2)    | [1.7.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.7.0.0)   | deprecated                                                                  |
-| 9.0.2        | [latest](https://github.com/haskell/haskell-language-server/releases/latest)         | full support                                                                |
+| 9.0.2        | [2.4.0.0](https://github.com/haskell/haskell-language-server/releases/tag/2.4.0.0)   | deprecated                                                                  |
 | 9.0.1        | [1.6.1.0](https://github.com/haskell/haskell-language-server/releases/tag/1.6.1.0)   | deprecated                                                                  |
 | 8.10.7       | [2.2.0.0](https://github.com/haskell/haskell-language-server/releases/tag/2.2.0.0)   | deprecated                                                                  |
 | 8.10.6       | [1.6.1.0](https://github.com/haskell/haskell-language-server/releases/tag/1.6.1.0)   | deprecated                                                                  |

docs/support/plugin-support.md

@@ -60,7 +60,7 @@ For example, a plugin to provide a formatter which has itself been abandoned has
 | `hls-ormolu-plugin`                 | 2    | 9.8                      |
 | `hls-rename-plugin`                 | 2    | 9.8                      |
 | `hls-stylish-haskell-plugin`        | 2    | 9.8                      |
-| `hls-overloaded-record-dot-plugin`  | 2    | 9.0                      |
+| `hls-overloaded-record-dot-plugin`  | 2    |                          |
 | `hls-floskell-plugin`               | 3    | 9.6, 9.8                 |
 | `hls-stan-plugin`                   | 3    | 9.2.(4-8)                |
 | `hls-retrie-plugin`                 | 3    | 9.8                      |

ghcide/ghcide.cabal

@@ -28,13 +28,6 @@ source-repository head
   type:     git
   location: https://github.com/haskell/haskell-language-server.git
 
-flag ghc-patched-unboxed-bytecode
-  description:
-    The GHC version we link against supports unboxed sums and tuples in bytecode
-
-  default:     False
-  manual:      True
-
 flag ekg
   description:
     Enable EKG monitoring of the build graph and other metrics on port 8999
@@ -232,9 +225,6 @@ library
     -Wall -Wincomplete-uni-patterns -Wno-unticked-promoted-constructors
     -Wunused-packages -fno-ignore-asserts
 
-  if flag(ghc-patched-unboxed-bytecode)
-    cpp-options: -DGHC_PATCHED_UNBOXED_BYTECODE
-
   if flag(pedantic)
     -- We eventually want to build with Werror fully, but we haven't
     -- finished purging the warnings, so some are set to not be errors

ghcide/session-loader/Development/IDE/Session.hs

@@ -40,8 +40,8 @@ import           Data.Function
 import           Data.Hashable                        hiding (hash)
 import qualified Data.HashMap.Strict                  as HM
 import           Data.List
+import           Data.List.NonEmpty                   (NonEmpty (..))
 import qualified Data.List.NonEmpty                   as NE
-import           Data.List.NonEmpty                   (NonEmpty(..))
 import qualified Data.Map.Strict                      as Map
 import           Data.Maybe
 import           Data.Proxy
@@ -826,7 +826,7 @@ newComponentCache recorder exts cradlePath cfp hsc_env uids ci = do
 #if MIN_VERSION_ghc(9,3,0)
       -- Set up a multi component session with the other units on GHC 9.4
         Compat.initUnits (map snd uids) (hscSetFlags df hsc_env)
-#elif MIN_VERSION_ghc(9,2,0)
+#else
       -- This initializes the units for GHC 9.2
       -- Add the options for the current component to the HscEnv
       -- We want to call `setSessionDynFlags` instead of `hscSetFlags`
@@ -837,9 +837,6 @@ newComponentCache recorder exts cradlePath cfp hsc_env uids ci = do
       evalGhcEnv hsc_env $ do
         _ <- setSessionDynFlags $ df
         getSession
-#else
-      -- getOptions is enough to initialize units on GHC <9.2
-      pure $ hscSetFlags df hsc_env { hsc_IC = (hsc_IC hsc_env) { ic_dflags = df } }
 #endif
 
     let newFunc = maybe newHscEnvEqPreserveImportPaths newHscEnvEq cradlePath

ghcide/src/Development/IDE/Core/Compile.hs

@@ -110,27 +110,17 @@ import           System.IO.Extra                   (fixIO, newTempFileWithin)
 
 import           GHC.Tc.Gen.Splice
 
-#if !MIN_VERSION_ghc(9,2,1)
-import           GHC.Driver.Types
-#endif
 
-#if !MIN_VERSION_ghc(9,2,0)
-import qualified Data.IntMap.Strict                as IntMap
-#endif
 
-#if MIN_VERSION_ghc(9,2,0)
 import qualified GHC                               as G
-#endif
 
-#if MIN_VERSION_ghc(9,2,0) && !MIN_VERSION_ghc(9,3,0)
+#if !MIN_VERSION_ghc(9,3,0)
 import           GHC                               (ModuleGraph)
 #endif
 
-#if MIN_VERSION_ghc(9,2,1)
 import           GHC.Types.ForeignStubs
 import           GHC.Types.HpcInfo
 import           GHC.Types.TypeEnv
-#endif
 
 #if !MIN_VERSION_ghc(9,3,0)
 import           Data.Map                          (Map)
@@ -265,7 +255,6 @@ captureSplicesAndDeps TypecheckHelpers{..} env k = do
            ; lintInteractiveExpr "hscCompileExpr" hsc_env prepd_expr
 
 
-#if MIN_VERSION_ghc(9,2,0)
            ; let iNTERACTIVELoc = G.ModLocation{ ml_hs_file   = Nothing,
                                         ml_hi_file   = panic "hscCompileCoreExpr':ml_hi_file",
                                         ml_obj_file  = panic "hscCompileCoreExpr':ml_obj_file",
@@ -293,11 +282,6 @@ captureSplicesAndDeps TypecheckHelpers{..} env k = do
                        (icInteractiveModule ictxt)
                        stg_expr
                        [] Nothing
-#else
-             {- Convert to BCOs -}
-           ; bcos <- coreExprToBCOs hsc_env
-                       (icInteractiveModule (hsc_IC hsc_env)) prepd_expr
-#endif
 
             -- Exclude wired-in names because we may not have read
             -- their interface files, so getLinkDeps will fail
@@ -312,11 +296,7 @@ captureSplicesAndDeps TypecheckHelpers{..} env k = do
                                            moduleName mod -- On <= 9.2, just the name is enough because all unit ids will be the same
 #endif
 
-#if MIN_VERSION_ghc(9,2,0)
                                          | n <- concatMap (uniqDSetToList . bcoFreeNames) $ bc_bcos bcos
-#else
-                                         | n <- uniqDSetToList (bcoFreeNames bcos)
-#endif
                                          , Just mod <- [nameModule_maybe n] -- Names from other modules
                                          , not (isWiredInName n) -- Exclude wired-in names
                                          , moduleUnitId mod `elem` home_unit_ids -- Only care about stuff from the home package set
@@ -357,13 +337,10 @@ captureSplicesAndDeps TypecheckHelpers{..} env k = do
              {- load it -}
            ; (fv_hvs, lbss, pkgs) <- loadDecls (hscInterp hsc_env') hsc_env' srcspan bcos
            ; let hval = ((expectJust "hscCompileCoreExpr'" $ lookup (idName binding_id) fv_hvs), lbss, pkgs)
-#elif MIN_VERSION_ghc(9,2,0)
+#else
              {- load it -}
            ; fv_hvs <- loadDecls (hscInterp hsc_env') hsc_env' srcspan bcos
            ; let hval = (expectJust "hscCompileCoreExpr'" $ lookup (idName binding_id) fv_hvs)
-#else
-             {- link it -}
-           ; hval <- linkExpr hsc_env' srcspan bcos
 #endif
 
            ; modifyIORef' var (flip extendModuleEnvList [(mi_module $ hm_iface hm, linkableHash lb) | lb <- lbs, let hm = linkableHomeMod lb])
@@ -881,7 +858,7 @@ generateHieAsts hscEnv tcm =
   where
     dflags = hsc_dflags hscEnv
     run _ts = -- ts is only used in GHC 9.2
-#if MIN_VERSION_ghc(9,2,0) && !MIN_VERSION_ghc(9,3,0)
+#if !MIN_VERSION_ghc(9,3,0)
         fmap (join . snd) . liftIO . initDs hscEnv _ts
 #else
         id
@@ -1189,15 +1166,15 @@ getModSummaryFromImports env fp _modTime mContents = do
 
 
         convImport (L _ i) = (
-#if !MIN_VERSION_ghc (9,3,0)
+#if !MIN_VERSION_ghc(9,3,0)
                                fmap sl_fs
 #endif
                                (ideclPkgQual i)
                              , reLoc $ ideclName i)
 
         msrImports = implicit_imports ++ imps
 
-#if MIN_VERSION_ghc (9,3,0)
+#if MIN_VERSION_ghc(9,3,0)
         rn_pkg_qual = renameRawPkgQual (hsc_unit_env ppEnv)
         rn_imps = fmap (\(pk, lmn@(L _ mn)) -> (rn_pkg_qual mn pk, lmn))
         srcImports = rn_imps $ map convImport src_idecls
@@ -1714,9 +1691,6 @@ getDocsBatch hsc_env _names = do
 #else
                                   Map.lookup name dmap ,
 #endif
-#if !MIN_VERSION_ghc(9,2,0)
-                                  IntMap.fromAscList $ Map.toAscList $
-#endif
 #if MIN_VERSION_ghc(9,3,0)
                                   lookupWithDefaultUniqMap amap mempty name))
 #else
@@ -1739,12 +1713,7 @@ lookupName :: HscEnv
 lookupName _ name
   | Nothing <- nameModule_maybe name = pure Nothing
 lookupName hsc_env name = exceptionHandle $ do
-#if MIN_VERSION_ghc(9,2,0)
   mb_thing <- liftIO $ lookupType hsc_env name
-#else
-  eps <- liftIO $ readIORef (hsc_EPS hsc_env)
-  let mb_thing = lookupType (hsc_dflags hsc_env) (hsc_HPT hsc_env) (eps_PTE eps) name
-#endif
   case mb_thing of
     x@(Just _) -> return x
     Nothing

ghcide/src/Development/IDE/Core/Rules.hs

@@ -697,12 +697,10 @@ dependencyInfoForFiles fs = do
       mg = mkModuleGraph mns
 #else
   let mg = mkModuleGraph $
-#if MIN_VERSION_ghc(9,2,0)
         -- We don't do any instantiation for backpack at this point of time, so it is OK to use
         -- 'extendModSummaryNoDeps'.
         -- This may have to change in the future.
           map extendModSummaryNoDeps $
-#endif
           (catMaybes mss)
 #endif
   pure (fingerprintToBS $ Util.fingerprintFingerprints $ map (maybe fingerprint0 msrFingerprint) msrs, processDependencyInformation rawDepInfo bm mg)
@@ -822,12 +820,10 @@ ghcSessionDepsDefinition fullModSummary GhcSessionDepsConfig{..} env file = do
                       nubOrdOn mkNodeKey (ModuleNode final_deps ms : concatMap mgModSummaries' mgs)
 #else
                 let module_graph_nodes =
-#if MIN_VERSION_ghc(9,2,0)
                       -- We don't do any instantiation for backpack at this point of time, so it is OK to use
                       -- 'extendModSummaryNoDeps'.
                       -- This may have to change in the future.
                       map extendModSummaryNoDeps $
-#endif
                       nubOrdOn ms_mod (ms : concatMap mgModSummaries mgs)
 #endif
                 liftIO $ evaluate $ liftRnf rwhnf module_graph_nodes
@@ -1219,12 +1215,7 @@ uses_th_qq (ms_hspp_opts -> dflags) =
 -- Depends on whether it uses unboxed tuples or sums
 computeLinkableTypeForDynFlags :: DynFlags -> LinkableType
 computeLinkableTypeForDynFlags d
-#if defined(GHC_PATCHED_UNBOXED_BYTECODE) || MIN_VERSION_ghc(9,2,0)
           = BCOLinkable
-#else
-          | _unboxed_tuples_or_sums = ObjectLinkable
-          | otherwise              = BCOLinkable
-#endif
   where -- unboxed_tuples_or_sums is only used in GHC < 9.2
         _unboxed_tuples_or_sums =
             xopt LangExt.UnboxedTuples d || xopt LangExt.UnboxedSums d

ghcide/src/Development/IDE/GHC/CPP.hs

@@ -63,9 +63,5 @@ doCpp env input_fn output_fn =
     let cpp_opts = True in
 #endif
 
-#if MIN_VERSION_ghc(9,2,0)
     Pipeline.doCpp (hsc_logger env) (hsc_tmpfs env) (hsc_dflags env) (hsc_unit_env env) cpp_opts input_fn output_fn
-#else
-    Pipeline.doCpp (hsc_dflags env) cpp_opts input_fn output_fn
-#endif