feat: add support for other namespaces (#240) #306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchoutri
reviewed
Nov 29, 2025
Comment on lines
59
to
60
| = Hackage PackageName | ||
| | Repository RepositoryURL RepositoryName PackageName |
Contributor
There was a problem hiding this comment.
I don't think you want to make Hackage more special than the others. Maybe a Pattern to build a Hackage package with pre-filled values would be useful, but I don't think it should be its own constructor.
tchoutri
reviewed
Nov 29, 2025
Comment on lines
64
to
66
| newtype PackageName | ||
| = PackageName { unPackageName :: Text } | ||
| deriving stock (Eq, Ord, Show) |
Contributor
There was a problem hiding this comment.
You should do like Flora and use as many lib:Cabal types as possible, like https://hackage-content.haskell.org/package/Cabal-syntax-3.16.0.0/docs/Distribution-Types-PackageName.html#t:PackageName
tchoutri
reviewed
Nov 30, 2025
| hackage = Repository (RepositoryURL "https://hackage.haskell.org") (RepositoryName "hackage") | ||
|
|
||
| newtype RepositoryURL | ||
| = RepositoryURL { unRepositoryURL :: Text } |
Contributor
There was a problem hiding this comment.
Are you sure this shouldn't be a proper URI or URL type?
Collaborator
Author
There was a problem hiding this comment.
At this point it's not that important, that being said, if you have any good library to integrate, I'd be grateful
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hsec-tools
/cc @tchoutri