Merge rust-bitcoin/rust-miniscript#746: fix: sync max multi_a pubkey with core

96d8662b70d1ea40d8ee850da68dac3e434f1220 fix: sync max multi_a pubkey with core (Chris Hyunhum Cho)

Pull request description:

  Although this is checked indirectly by checking MAX_STACK_SIZE, it'd be better to check in threshold explicitly as core does.

ACKs for top commit:
  apoelstra:
    ACK 96d8662b70d1ea40d8ee850da68dac3e434f1220 successfully ran local tests
  sanket1729:
    ACK 96d8662b70d1ea40d8ee850da68dac3e434f1220

Tree-SHA512: 77af95e605ea2a26b92f54d5b16e1078396ac548d5a57b29afef0207061631c32c0577c11c6c23ae87a2c2c6753e8445c0137d379570a3b993dc4b41a1cade3d

Author: heap-coder

src/miniscript/limits.rs

@@ -34,4 +34,5 @@ pub const MAX_BLOCK_WEIGHT: usize = 4000000;
 // https://github.com/bitcoin/bitcoin/blob/6acda4b00b3fc1bfac02f5de590e1a5386cbc779/src/script/script.h#L30
 pub const MAX_PUBKEYS_PER_MULTISIG: usize = 20;
 /// Maximum pubkeys in a CHECKSIGADD construction.
-pub const MAX_PUBKEYS_IN_CHECKSIGADD: usize = (bitcoin::Weight::MAX_BLOCK.to_wu() / 32) as usize;
+// https://github.com/bitcoin/bitcoin/blob/99b06b7f1d4194fb8036b90e5308101645f968e7/src/script/script.h#L36
+pub const MAX_PUBKEYS_IN_CHECKSIGADD: usize = 999;