Skip to content

[BUG] SDK: tests fail in @defai/element-types & repo includes node_modules #1

@maclorlando

Description

@maclorlando

Summary

While setting up and auditing the SDK repo, I found two issues:

  • @defai/element-types failed its test script because it lacked a tsconfig.json.
  • The repository included node_modules/ and lacked proper .gitignore rules.

Steps to Reproduce

1️⃣ Clone the repo
2️⃣ Run:

npm install
npm test

3️⃣ Observe:

× @defai/element-types:test
…and note that node_modules/ is checked into version control.

Fixes Implemented (see PR #2)
✅ Added tsconfig.json to types/ to allow tsc --noEmit to pass.
✅ Added /node_modules to .gitignore.
✅ Removed node_modules/ from the repo.

Results
✅ npm install, npm run build, and npm test now all succeed.
✅ All 6 packages pass tests.
✅ .gitignore properly excludes node_modules/.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions