-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/duration mjo #2
base: master
Are you sure you want to change the base?
Conversation
package.json
Outdated
| "version": "2.0.6", | ||
| "author": "Jeff Dickey @dickeyxxxx", | ||
| "dependencies": { | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use fixpack to fix this up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i ran fixpack package and committed the changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, do we have any documentation for a checklist of things to do before submitting a PR? Like "run fixpack, use xyz formatter", etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, everything needing to be done is done with CI. Fixpack isn't crucial, I just wanted to get rid of the empty line mostly
src/commands/printbricks.js
Outdated
| DurationFlag | ||
| ] | ||
| run() { | ||
| let duration = new Duration(this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can put this above:
static flags = [
DurationFlag
]
duration = new Duration(this)
run() {There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
…xample-plugin into feature/duration-mjo
|
good to merge when CI passes |
src/commands/dynorestart.js
Outdated
| } | ||
|
|
||
| main () { | ||
| return new Promise(resolve => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a way you could make this cleaner is by creating a utility function wait:
const wait = msg => new Promise(resolve => setTimeout(resolve, ms))Then use it here like this:
await wait(5000)
console.log('Done restarting dynos')You could reuse it below as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed
c06a8dc to
3a25d18
Compare
|
CI checks keep failing. I do not think it is anything wrong with the code itself, rather I think it is running a test and does not pass the duration flag, and so that is causing the undefined error seen. @dickeyxxx may I have your input? |
6f0ba5b to
294ae55
Compare
294ae55 to
7e27a68
Compare
No description provided.