Skip to content
This repository was archived by the owner on Oct 16, 2024. It is now read-only.

Conversation

@KarateCowboy
Copy link

No description provided.

package.json Outdated
"version": "2.0.6",
"author": "Jeff Dickey @dickeyxxxx",
"dependencies": {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fixpack to fix this up

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i ran fixpack package and committed the changes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, do we have any documentation for a checklist of things to do before submitting a PR? Like "run fixpack, use xyz formatter", etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, everything needing to be done is done with CI. Fixpack isn't crucial, I just wanted to get rid of the empty line mostly

DurationFlag
]
run() {
let duration = new Duration(this)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can put this above:

static flags = [
    DurationFlag
  ]
  duration = new Duration(this)
  run() {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jdx
Copy link
Contributor

jdx commented Mar 16, 2017

good to merge when CI passes

}

main () {
return new Promise(resolve => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a way you could make this cleaner is by creating a utility function wait:

const wait = msg => new Promise(resolve => setTimeout(resolve, ms))

Then use it here like this:

await wait(5000)
console.log('Done restarting dynos')

You could reuse it below as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed

@KarateCowboy KarateCowboy force-pushed the feature/duration-mjo branch from c06a8dc to 3a25d18 Compare March 17, 2017 16:04
@KarateCowboy
Copy link
Author

CI checks keep failing. I do not think it is anything wrong with the code itself, rather I think it is running a test and does not pass the duration flag, and so that is causing the undefined error seen. @dickeyxxx may I have your input?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants