Do not mention hibernate-ide-codestyles
#312
Conversation
| /* | ||
| * SPDX-License-Identifier: Apache-2.0 | ||
| * Copyright Red Hat Inc. and Hibernate Authors | ||
| */ |
There was a problem hiding this comment.
though ... I noticed Reactive is using a slight variation of this format:
| Each Hibernate project includes a set of build plugins to format and verify the code style of the sources. | ||
| Please refer to the particular project contributing guide for more details. |
There was a problem hiding this comment.
Uh, okay, but Hibernate ORM for example redirects here:
https://github.com/hibernate/hibernate-orm/blob/main/CONTRIBUTING.md#guidelines
There was a problem hiding this comment.
😭 😖 infinite loop
though I have some slight doubts that everyone follows these instructions...
otherwise we'd be getting all new PRs with the old LGPL headers 😕
There was a problem hiding this comment.
I don't really care about instructions for the headers since they're checked automatically on build, but the code style, IIRC, is not always checked in Hibernate ORM, and anyway it's convenient to have instructions on how to set up the IDE...
But those instructions would definitely be better to have in CONTRIBUTING.md, that I can agree with. The question is... what should those instructions be, if we archive hibernate-ide-codestyles :)
There was a problem hiding this comment.
how about something like ^
we tell to run the checks (and if someone doesn't CI should catch it, right?) and we give the links to the IDE pages, but we don't say that they have the styles .... 🫣 🙂
2 participants
LGPL info is a bit outdated 🫣 🙂