Settings are not saved

[z33ky]

I thought this was a Linux issue or something, but looking closer at the code I think this is true for Windows as well.
If you delete the "persist.dat", start the game and modify settings, they will not be remembered the next time you open Oni.

The ONrPersist() function is supposed to store these settings in the "persist.dat".

OniFoxed/OniProj/OniGameSource/Oni_Persistance.c

Lines 152 to 163 in 9362f44

	static void ONrPersist(void)
	{
	BFtFile *stream = BFrFile_FOpen(ONcPersistance_FileName, "w");
	UUtError error;
	if (NULL != stream) {
	error = BFrFile_Write(stream, sizeof(ONtPersistance), &ONgPersistance);
	BFrFile_Close(stream);
	}
	return;
	}

However, BFrFile_FOpen() will error out since it uses BFrFileRef_Set() which returns BFcError_FileNotFound if the file doesn't already exist.

OniFoxed/BungieFrameWork/BFW_Source/BFW_FileManager/Platform_Win32/BFW_FileManager_Win32.c

Lines 162 to 184 in 9362f44

	UUtError
	BFrFileRef_Set(
	BFtFileRef* inFileRef,
	const char* inFileName) // like make from name but does not create
	{
	UUtError error;
	UUmAssert(NULL != inFileRef);
	UUmAssert(NULL != inFileName);
	if(strlen(inFileName) >= BFcMaxPathLength)
	{
	UUmError_ReturnOnErrorMsg(UUcError_Generic, "Path name too long");
	}
	/* Make sure the path name is valid */
	error = BFiCheckFileName(inFileName);
	UUmError_ReturnOnError(error);
	if(BFiFileRef_PathNameExists(inFileName) == UUcFalse)
	{
	return BFcError_FileNotFound;
	}

Indeed there doesn't seem to be a good way to create a file at all in the provided API.
Looking at how BFrFile_Create() is used it seems likely that creating a BFtFileRef to a non-existing file shouldn't actually error out.

[madebr]

Indeed, it seems to me that BFrFileRef_Set should not error when the file does not exist.
See this usage:

OniFoxed/BungieFrameWork/BFW_Source/BFW_FileManager/BFW_FileManager_Common.c

Lines 102 to 108 in 9362f44

	error = BFrFileRef_Set(outFileRef, temp);
	if(UUcError_None == error) {
	if (BFrFileRef_FileExists(outFileRef)) {
	return UUcError_None;
	}
	}

It expects UUcError_None on success + does an extra test for existence for that file.

Luckily, there are not that many usages of BFrFileRef_Set.
I think only this usage needs some extra checks.

[z33ky]

I think only this usage needs some extra checks.

I'm not sure it does. BFrFile_Open(file, "r") will eventually return the BFcError_FileNotFound, I don't know why creating the BFtFileRef should.
In fact, I'm not sure what BFrFileRef_MakeFromName() is supposed to do compared to BFtFileRef fileRef = {{0}}; UUtError error = BFrFileRef_Set(fileRef, inFileName);. It stores the BFtFileRef on the heap, which is, err, great? Something the caller should decide I would think.