null id for submission.update webhook payload

[JoacoG]

Describe the bug
id value is null in webhook payload

To Reproduce
Create a POST webhook in n8n and configure that in central-webhook.

Then review a submission and see webhook payload in n8n.

id should be null.

Expected behavior
id should be the uuid of the reviewed submission.

Screenshots

n8n webhook output:

audits table entry for submission.update

Additional context

audits table in PostgreSQL seems OK.

[JoacoG]

I added this in the trigger function definition

-- Log trigger activation
RAISE WARNING 'Trigger % activated on %: OLD=% NEW=%', 
     TG_NAME, TG_OP, OLD, NEW;

and got this for submission.update

and this for submission.create

Apparently submission.update entries does not have "instanceId" in details, at least in this case.

This could be a problem in my end?

If this is not a problem in my end, that means that the specific submission form which was updated cannot be retrieved unless this is added in ODK source code?

PD: I think you could retrive uuid from submission table using submissionId

[spwoodcock]

This will probably take more time than I have right now to debug unfortunately 😅

Either my updates have broken functionality, the central database schema has changed, or perhaps its an issue with the data as you mention.

[JoacoG]

In the meantime, I changed some lines in the trigger to retrieve submission uuid using submissionId. This should work at least to test my workflow, as I need this uuid to retrieve submission data.

[spwoodcock]

In the meantime, I changed some lines in the trigger to retrieve submission uuid using submissionId. This should work at least to test my workflow, as I need this uuid to retrieve submission data.

Sounds good! If you fix the issue through testing, a PR would be welcome, or even just posting the updated code here 🙏

[JoacoG]

About this. doing what I said to you above I was able to retrieve instanceId. But I'm not sure if that info should be obtained that way. Maybe instanceId should be in details and for some reason is not appearing here. I asked in the forum but I have no answer yet there.

You also do some duplicate check using instanceId, but if this instanceId is not in details that check is a bit more complicated. See the check here:

In the meantime, I'll just use this fix to set my workflow, until this is fixed properly.