rewrite sqlvet using analysis.Analyzer?

[yasushi-saito]

The current sqlvet requires full parsing of the entire main package(s), so it becomes pretty slow for a large codebase. There's conveniently an article about using "go vet"'s analysis.Analyzer framework to detect SQL statements:

https://agniva.me/vet/2019/01/21/vet-analyzer.html

Does it make sense to rewrite sqlvet using it? I can try my hand over the holidays if you think it's a good idea.

[houqp]

I am all for rewriting sqlvet with a new design that can yield better performance, so feel free to give it a try ;)

As for checking the entire main package, isn't it what we always want to do so we don't miss SQL statements in main?

[yasushi-saito]

Well, we sometimes want to check just a specific set of files. For example, we are using this tool in a git pre-commit hook. In such a case, it's better to check only the changed files.

[houqp]

Got it, that makes sense :)

[yasushi-saito]

#8 is a first cut.