Links containing spaces are not parsed correctly

[autarch]

Migrated from rt.cpan.org #92251 (status was 'open')

Requestors:

• PJF@cpan.org (@pjf)
• cpan@zoffix.com (@zoffixznet)

Attachments:

• SpanParser-URL-Title-Handling.patch

From pjf@cpan.org (@pjf) on 2014-01-18 08:12:01:

The markdown standard says that links can have an optional title, which must be enclosed in double quotes. However markdent considers anything past the first space in a URL to be the title, and cares not for quotes. This means a URL like:

[some text](http://example.com/Your Page.html)

results in a truncated URL of http://example.com/Your.

This should be a simple tweak to Markdent::Parser::SpanParser::_parse_uri_and_title(), but it appears that I can't brain today, so a patch is not yet included.

~ pjf

[autarch]

From cpan@zoffix.com (@zoffixznet) on 2014-01-20 01:25:17:

Patch supplied: https://rt.cpan.org/Ticket/Display.html?id=92273

Thanks for reporting.

[autarch]

From drolsky@cpan.org (@autarch) on 2014-01-20 23:21:37:

On Sun Jan 19 20:24:19 2014, ZOFFIX wrote:

Attached is the patch that fixes
https://rt.cpan.org/Ticket/Display.html?id=92251

Cheers,
ZZ [ https://metacpan.org/author/ZOFFIX ]

For future reference, you can just comment on the original ticket.

Thanks,

-dave

[autarch]

From drolsky@cpan.org (@autarch) on 2014-01-25 22:20:35:

On Sat Jan 18 03:12:01 2014, PJF wrote:

The markdown standard says that links can have an optional title,
which must be enclosed in double quotes. However markdent considers
anything past the first space in a URL to be the title, and cares not
for quotes. This means a URL like:

[some text](http://example.com/Your Page.html)

Is this actually a valid link? Shouldn't that be Your%20Page.html?

[autarch]

From cpan@zoffix.com (@zoffixznet) on 2014-01-25 22:39:32:

On Sat Jan 25 17:20:35 2014, DROLSKY wrote:

Is this actually a valid link? Shouldn't that be Your%20Page.html?

It's not a valid link, but in the sense that browsers will interpret the space as %20, follow it properly, display it in the URL bar as a space, and escape it to %20 when copy/pasting from URL bar, then it's "valid" :)

Here's a test case: http://zoffix.com/new/del/space%20in-link.html
And its validation: http://validator.w3.org/check?verbose=1&uri=http%3A%2F%2Fzoffix.com%2Fnew%2Fdel%2Fspace%2520in-link.html

One thing to note is that markdown specifies the optional title has to be quoted, so assuming there's a title by splitting on a space isn't correct. (I've used this document for my reference: http://daringfireball.net/projects/markdown/syntax#link )

--

Cheers,
ZZ [ https://metacpan.org/author/ZOFFIX ]