portico-gateway.js swallowing errors and running callback multiple times

[charlie-s]

In lib/services/portico-gateway.js, PorticoGateway.submitTransaction, we have this block:

try {
    callback(null, {header: h, body: gatewayResult['Ver1.0'][0].Transaction[0]});
} catch (e) {
    callback(null, {header: h});
}

As you can see, any errors thrown in the callback are swallowed and the callback is then run a 2nd time. What does the try/catch accomplish here?

[slogsdon]

@charlie-s Apologies for missing this originally! Agreed that the try/catch block there isn't a good solution for these cases. We're working on a small update to address this.