-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
Description
Consider a refactor of code for formatting numeric values into a helper function (rounding), and add unit tests
Here are 5 places where we round the value of a score. Could we just do it once?
Line 581 in f268127
text_value = text_value.toFixed(get_round_decimals(col_name)); Line 745 in f268127
hovertemplate: `model: %{data.name}<br>${thisState.selected_disaggregate_by}: %{x}<br>${score_col_name_to_text(this.state.selected_metric)}: %{y:.${get_round_decimals(this.state.selected_metric)}f}<extra></extra>`, Line 782 in f268127
colorbar_tick_format = `.${get_round_decimals(this.state.selected_metric)}f`; Line 820 in f268127
colorbar_tick_format = `.${get_round_decimals(this.state.selected_metric)}f`; Line 911 in f268127
hovertemplate: `${thisState.selected_disaggregate_by}: %{x}<br>model: %{y}<br>${score_col_name_to_text(this.state.selected_metric)}: %{customdata:.${get_round_decimals(this.state.selected_metric)}f}<extra></extra>`,
this is probably very low priority
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Todo