Revert AutoencoderKLWan's dim_mult default value back to list
#12640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR reverts the default value for the
dim_multargument toAutoencoderKLWan.__init__back to aList(e.g.[1, 2, 4, 4]instead of(1, 2, 4, 4)). The rationale behind this is that some code of the Wan VAE code assumes thatdim_multis typeList, such asdiffusers/src/diffusers/models/autoencoders/autoencoder_kl_wan.py
Line 542 in 093cd3f
This causes errors when
dim_multis not explicitly set, such as inconvert_vae()inscripts/convert_wan_to_diffusers.py.dim_multdefaulted to aListprior to #12544, but was incorrectly annotated as typeTuple[int], so I believe that PR inadvertently changed the default argument to aTuple. I have changed the type annotation toList[int]in this PR.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@yiyixuxu