From 16b5b24bdf9a41148678b9e43cd5dc82800da726 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Mon, 17 Nov 2025 15:37:07 +0100 Subject: [PATCH 01/22] misc(build-pr): update to actions/checkout v5 --- .github/workflows/build-pr-mac.yaml | 2 +- .github/workflows/build-pr.yaml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-pr-mac.yaml b/.github/workflows/build-pr-mac.yaml index 979a6f8..8859bd2 100644 --- a/.github/workflows/build-pr-mac.yaml +++ b/.github/workflows/build-pr-mac.yaml @@ -11,7 +11,7 @@ jobs: build-kernel: runs-on: macos-15 steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: DeterminateSystems/nix-installer-action@v20 with: extra-conf: | diff --git a/.github/workflows/build-pr.yaml b/.github/workflows/build-pr.yaml index 6793080..b419c7b 100644 --- a/.github/workflows/build-pr.yaml +++ b/.github/workflows/build-pr.yaml @@ -12,7 +12,7 @@ jobs: runs-on: group: aws-highmemory-32-plus-nix steps: - - uses: actions/checkout@v4 + - uses: actions/checkout@v5 - uses: DeterminateSystems/nix-installer-action@main with: extra-conf: | From ea02c95830a1706a7d389ea5820e79e097c37e89 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 09:14:54 +0100 Subject: [PATCH 02/22] misc(build-pr): ok let's try to setup the pipeline for windows --- .github/workflows/build-pr-windows.yaml | 74 +++++++++++++++++++++++++ 1 file changed, 74 insertions(+) create mode 100644 .github/workflows/build-pr-windows.yaml diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml new file mode 100644 index 0000000..73c7131 --- /dev/null +++ b/.github/workflows/build-pr-windows.yaml @@ -0,0 +1,74 @@ +name: Build PR (Windows) +on: + push: + branches: ['windows-build-*'] +# pull_request: +# paths-ignore: +# - "**/README.md" +concurrency: + group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} + cancel-in-progress: true + +jobs: + build-kernel: + strategy: + matrix: + os: [ windows-2022 ] + python: [ 3.11, 3.12 ] + torch: [ + # { version: '2.9.1', cuda: '12.6.3', wheel: '126' }, + { version: '2.9.1', cuda: '12.8.1', wheel: '128' }, + # { version: '2.9.1', cuda: '13.0.1', wheel: '130' } + ] + + runs-on: windows-2022 + steps: + - uses: Jimver/cuda-toolkit@v0.2.29 + id: setup-cuda-toolkit + with: + cuda: ${{ matrix.torch.cuda }} + + - name: Install PyTorch + run: pip install torch --index-url https://download.pytorch.org/whl/cu${{ matrix.torch.wheel }} + + - uses: actions/checkout@v5 + - name: Validate kernel directory + id: validate + run: | + PR_TITLE="${{ github.event.pull_request.title }}" + if KERNEL=$(python3 .github/workflows/validate-kernel-pr.py "pr" "$PR_TITLE"); then + echo "kernel=$KERNEL" >> $GITHUB_OUTPUT + echo "skip=false" >> $GITHUB_OUTPUT + else + echo "skip=true" >> $GITHUB_OUTPUT + fi + + - name: Checkout kernel-builder + if: steps.validate.outputs.skip == 'false' + uses: actions/checkout@v5 + with: + repository: huggingface/kernel-builder + path: kernel-builder + + - name: Cache Rust build + if: steps.validate.outputs.skip == 'false' + uses: actions/cache@v4 + with: + path: | + kernel-builder/build2cmake/target + ~/.cargo/registry + ~/.cargo/git + key: ${{ runner.os }}-rust-debug-${{ hashFiles('kernel-builder/build2cmake/Cargo.lock') }} + restore-keys: | + ${{ runner.os }}-rust-debug- + + - name: Build build2cmake + if: steps.validate.outputs.skip == 'false' + working-directory: kernel-builder/build2cmake + run: cargo build + + - name: Build kernel + if: steps.validate.outputs.skip == 'false' + run: | + KERNEL="${{ steps.validate.outputs.kernel }}" + echo "$KERNEL" \ No newline at end of file From 9f790852795016ca91cf2ac6d6131ee7c52149f6 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 09:25:00 +0100 Subject: [PATCH 03/22] misc(build-pr): missing setup-python --- .github/workflows/build-pr-windows.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 73c7131..604ea7b 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -28,6 +28,10 @@ jobs: with: cuda: ${{ matrix.torch.cuda }} + - uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python }} + - name: Install PyTorch run: pip install torch --index-url https://download.pytorch.org/whl/cu${{ matrix.torch.wheel }} From 046d735e2b84230b3f4a763526d9963e0f51b6ab Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 10:52:39 +0100 Subject: [PATCH 04/22] misc(build-pr): updating code from bash to Powershell --- .github/workflows/build-pr-windows.yaml | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 604ea7b..b3c61ac 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -38,14 +38,17 @@ jobs: - uses: actions/checkout@v5 - name: Validate kernel directory id: validate + shell: pwsh run: | - PR_TITLE="${{ github.event.pull_request.title }}" - if KERNEL=$(python3 .github/workflows/validate-kernel-pr.py "pr" "$PR_TITLE"); then - echo "kernel=$KERNEL" >> $GITHUB_OUTPUT - echo "skip=false" >> $GITHUB_OUTPUT - else - echo "skip=true" >> $GITHUB_OUTPUT - fi + $PR_TITLE = "${{ github.event.pull_request.title }}" + $KERNEL = python .github/workflows/validate-kernel-pr.py "pr" "$PR_TITLE" + if ($LASTEXITCODE -eq 0) { + echo "kernel=$KERNEL" >> $env:GITHUB_OUTPUT + echo "skip=false" >> $env:GITHUB_OUTPUT + } else { + echo "skip=true" >> $env:GITHUB_OUTPUT + } + - name: Checkout kernel-builder if: steps.validate.outputs.skip == 'false' @@ -73,6 +76,7 @@ jobs: - name: Build kernel if: steps.validate.outputs.skip == 'false' + shell: pwsh run: | - KERNEL="${{ steps.validate.outputs.kernel }}" - echo "$KERNEL" \ No newline at end of file + $KERNEL = "${{ steps.validate.outputs.kernel }}" + Write-Output $KERNEL From 184f0d3fc46b236af32e161a73fa889ea9f6c1c7 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 11:28:54 +0100 Subject: [PATCH 05/22] misc(build-pr): debug --- .github/workflows/build-pr-windows.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index b3c61ac..11100ca 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -23,6 +23,8 @@ jobs: runs-on: windows-2022 steps: + - run: echo "${{ github.event.pull_request.title }}" + - uses: Jimver/cuda-toolkit@v0.2.29 id: setup-cuda-toolkit with: From f06cb070efcdb12763f4a8c78c2039aa83e022ca Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 11:32:36 +0100 Subject: [PATCH 06/22] misc(build-pr): enable only on pr to be able to retrieve title --- .github/workflows/build-pr-windows.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 11100ca..ce8ba78 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -1,10 +1,13 @@ name: Build PR (Windows) on: - push: - branches: ['windows-build-*'] -# pull_request: -# paths-ignore: -# - "**/README.md" +# push: +# branches: ['windows-build-*'] + pull_request: + types: [opened, synchronize] + paths-ignore: + - "**/README.md" + + concurrency: group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }} cancel-in-progress: true From e4085e4b9859fe23ec803fb92d43ef6bcd03110c Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 13:44:07 +0100 Subject: [PATCH 07/22] misc(build-pr): ok let's build? --- .github/workflows/build-pr-windows.yaml | 40 +++++++++++++++---------- 1 file changed, 24 insertions(+), 16 deletions(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index ce8ba78..894329d 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -26,20 +26,6 @@ jobs: runs-on: windows-2022 steps: - - run: echo "${{ github.event.pull_request.title }}" - - - uses: Jimver/cuda-toolkit@v0.2.29 - id: setup-cuda-toolkit - with: - cuda: ${{ matrix.torch.cuda }} - - - uses: actions/setup-python@v5 - with: - python-version: ${{ matrix.python }} - - - name: Install PyTorch - run: pip install torch --index-url https://download.pytorch.org/whl/cu${{ matrix.torch.wheel }} - - uses: actions/checkout@v5 - name: Validate kernel directory id: validate @@ -54,9 +40,31 @@ jobs: echo "skip=true" >> $env:GITHUB_OUTPUT } + - name: Kernel Info + shell: pwsh + run: | + $KERNEL = "${{ steps.validate.outputs.kernel }}" + Write-Output Building Kernel: "${{ KERNEL }}" + + - uses: Jimver/cuda-toolkit@v0.2.29 + if: steps.validate.outputs.skip == 'false' + id: setup-cuda-toolkit + with: + cuda: ${{ matrix.torch.cuda }} + + - name: Setup Python + if: steps.validate.outputs.skip == 'false' + uses: actions/setup-python@v5 + with: + python-version: ${{ matrix.python }} + + - name: Install PyTorch + if: steps.validate.outputs.skip == 'false' + run: pip install torch --index-url https://download.pytorch.org/whl/cu${{ matrix.torch.wheel }} - name: Checkout kernel-builder if: steps.validate.outputs.skip == 'false' + id: checkout-kernel-builder uses: actions/checkout@v5 with: repository: huggingface/kernel-builder @@ -83,5 +91,5 @@ jobs: if: steps.validate.outputs.skip == 'false' shell: pwsh run: | - $KERNEL = "${{ steps.validate.outputs.kernel }}" - Write-Output $KERNEL + KERNEL_BUILDER_PATH = "${{ steps.checkout-kernel-builder.outputs.path }}" + ${KERNEL_BUILDER_PATH}\scripts\windows\build.ps1 -SourceFolder ${KERNEL} -BuildConfig Release -Build From 53995909ff4e02c3a207454e3cd6e261089003c1 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 13:47:18 +0100 Subject: [PATCH 08/22] misc(build-pr): invalid escaping --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 894329d..13c1188 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -92,4 +92,4 @@ jobs: shell: pwsh run: | KERNEL_BUILDER_PATH = "${{ steps.checkout-kernel-builder.outputs.path }}" - ${KERNEL_BUILDER_PATH}\scripts\windows\build.ps1 -SourceFolder ${KERNEL} -BuildConfig Release -Build + ${KERNEL_BUILDER_PATH}\scripts\windows\build.ps1 -SourceFolder "${{ KERNEL }}" -BuildConfig Release -Build From 2cc10fdfd0f08bcdb445ac792085832f93ded89f Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 13:49:03 +0100 Subject: [PATCH 09/22] misc(build-pr): invalid escaping --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 13c1188..5625b72 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -92,4 +92,4 @@ jobs: shell: pwsh run: | KERNEL_BUILDER_PATH = "${{ steps.checkout-kernel-builder.outputs.path }}" - ${KERNEL_BUILDER_PATH}\scripts\windows\build.ps1 -SourceFolder "${{ KERNEL }}" -BuildConfig Release -Build + "${{ KERNEL_BUILDER_PATH}}\scripts\windows\build.ps1" -SourceFolder "${{ KERNEL }}" -BuildConfig Release -Build From 1623b214105c08cb10f566dfa17fbe8b72ee29a8 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 14:41:15 +0100 Subject: [PATCH 10/22] misc(build-pr): bllll --- .github/workflows/build-pr-windows.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 5625b72..22da806 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -41,10 +41,11 @@ jobs: } - name: Kernel Info + if: steps.validate.outputs.skip == 'false' shell: pwsh run: | $KERNEL = "${{ steps.validate.outputs.kernel }}" - Write-Output Building Kernel: "${{ KERNEL }}" + Write-Output "Building Kernel: $KERNEL" - uses: Jimver/cuda-toolkit@v0.2.29 if: steps.validate.outputs.skip == 'false' @@ -91,5 +92,5 @@ jobs: if: steps.validate.outputs.skip == 'false' shell: pwsh run: | - KERNEL_BUILDER_PATH = "${{ steps.checkout-kernel-builder.outputs.path }}" - "${{ KERNEL_BUILDER_PATH}}\scripts\windows\build.ps1" -SourceFolder "${{ KERNEL }}" -BuildConfig Release -Build + $KERNEL = "${{ steps.validate.outputs.kernel }}" + & "kernel-builder\scripts\windows\build.ps1" -SourceFolder $KERNEL -BuildConfig Release -Build From a847cd2cbbbc7820dcd46fdbe94e4041e366e8c2 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 14:53:25 +0100 Subject: [PATCH 11/22] misc(build-pr): what if I specify the kernel-builder path relative to GITHUB_WORKSPACE --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 22da806..7c62a57 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -93,4 +93,4 @@ jobs: shell: pwsh run: | $KERNEL = "${{ steps.validate.outputs.kernel }}" - & "kernel-builder\scripts\windows\build.ps1" -SourceFolder $KERNEL -BuildConfig Release -Build + "$GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1" -SourceFolder $KERNEL -BuildConfig Release -Build From 41c863aa3c12b34d70a705610fe02818a8ab7279 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 15:22:21 +0100 Subject: [PATCH 12/22] misc(build-pr): kk --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 7c62a57..8142a21 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -93,4 +93,4 @@ jobs: shell: pwsh run: | $KERNEL = "${{ steps.validate.outputs.kernel }}" - "$GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1" -SourceFolder $KERNEL -BuildConfig Release -Build + "$GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1 -SourceFolder $KERNEL -BuildConfig Release -Build" From a52489451293bc158d5be6a18baafa3c4de2855b Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 15:42:28 +0100 Subject: [PATCH 13/22] misc(build-pr): kkk --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 8142a21..120e4d6 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -93,4 +93,4 @@ jobs: shell: pwsh run: | $KERNEL = "${{ steps.validate.outputs.kernel }}" - "$GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1 -SourceFolder $KERNEL -BuildConfig Release -Build" + & "$GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1 -SourceFolder $KERNEL -BuildConfig Release -Build" From 0f4d9f0d47d8e0835e52af91cc56d6e9a6fb59fd Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 15:54:41 +0100 Subject: [PATCH 14/22] misc(build-pr): kkkk --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 120e4d6..78b4e06 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -93,4 +93,4 @@ jobs: shell: pwsh run: | $KERNEL = "${{ steps.validate.outputs.kernel }}" - & "$GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1 -SourceFolder $KERNEL -BuildConfig Release -Build" + & "$GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1" -SourceFolder "$KERNEL" -BuildConfig Release -Build From 79d600efb5aef8a34132e41c14e13cc7e9c80fb6 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 16:15:03 +0100 Subject: [PATCH 15/22] misc(build-pr): kkkkk --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 78b4e06..a171529 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -93,4 +93,4 @@ jobs: shell: pwsh run: | $KERNEL = "${{ steps.validate.outputs.kernel }}" - & "$GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1" -SourceFolder "$KERNEL" -BuildConfig Release -Build + & "$env:GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1" -SourceFolder "$KERNEL" -BuildConfig Release -Build From 80732f49159d005005aea4b60f8d413964100a29 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 16:31:55 +0100 Subject: [PATCH 16/22] misc(build-pr): kkkkkk --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index a171529..1ac53f0 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -93,4 +93,4 @@ jobs: shell: pwsh run: | $KERNEL = "${{ steps.validate.outputs.kernel }}" - & "$env:GITHUB_WORKSPACE\kernel-builder\scripts\windows\build.ps1" -SourceFolder "$KERNEL" -BuildConfig Release -Build + & "$env:GITHUB_WORKSPACE\kernel-builder\scripts\windows\builder.ps1" -SourceFolder "$KERNEL" -BuildConfig Release -Build From 95b61a91caa951729b61aadad79e993c72d824f8 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Tue, 18 Nov 2025 17:01:19 +0100 Subject: [PATCH 17/22] misc(build-pr): backend cuda for now --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 1ac53f0..1a33f96 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -93,4 +93,4 @@ jobs: shell: pwsh run: | $KERNEL = "${{ steps.validate.outputs.kernel }}" - & "$env:GITHUB_WORKSPACE\kernel-builder\scripts\windows\builder.ps1" -SourceFolder "$KERNEL" -BuildConfig Release -Build + & "$env:GITHUB_WORKSPACE\kernel-builder\scripts\windows\builder.ps1" -Backend cuda -SourceFolder "$KERNEL" -BuildConfig Release -Build From 8e13eb83a359e9082313779e9fe5e2900b3b00e4 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Wed, 19 Nov 2025 09:24:01 +0100 Subject: [PATCH 18/22] misc(build-pr): trying with cuda13 just in case it's a cuda error --- .github/workflows/build-pr-windows.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 1a33f96..14fe3fa 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -20,8 +20,8 @@ jobs: python: [ 3.11, 3.12 ] torch: [ # { version: '2.9.1', cuda: '12.6.3', wheel: '126' }, - { version: '2.9.1', cuda: '12.8.1', wheel: '128' }, - # { version: '2.9.1', cuda: '13.0.1', wheel: '130' } +# { version: '2.9.1', cuda: '12.8.1', wheel: '128' }, + { version: '2.9.1', cuda: '13.0.1', wheel: '130' } ] runs-on: windows-2022 From 2988dfa8110265dadf2582cc688c435a369610ed Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Wed, 19 Nov 2025 09:42:20 +0100 Subject: [PATCH 19/22] misc(build-pr): same with pytorch 2.8? --- .github/workflows/build-pr-windows.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 14fe3fa..61bcaae 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -21,7 +21,8 @@ jobs: torch: [ # { version: '2.9.1', cuda: '12.6.3', wheel: '126' }, # { version: '2.9.1', cuda: '12.8.1', wheel: '128' }, - { version: '2.9.1', cuda: '13.0.1', wheel: '130' } +# { version: '2.9.1', cuda: '13.0.1', wheel: '130' } + { version: '2.8.0', cuda: '12.8.1', wheel: '128' } ] runs-on: windows-2022 From 9b4ede2ad06b0940d70227aed50eb4ca5a005995 Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Wed, 19 Nov 2025 10:41:42 +0100 Subject: [PATCH 20/22] misc(build-pr): Use a fix on kernel-builder to force `_WIN32` definition --- .github/workflows/build-pr-windows.yaml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 61bcaae..8f8e8a2 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -20,9 +20,8 @@ jobs: python: [ 3.11, 3.12 ] torch: [ # { version: '2.9.1', cuda: '12.6.3', wheel: '126' }, -# { version: '2.9.1', cuda: '12.8.1', wheel: '128' }, + { version: '2.9.1', cuda: '12.8.1', wheel: '128' }, # { version: '2.9.1', cuda: '13.0.1', wheel: '130' } - { version: '2.8.0', cuda: '12.8.1', wheel: '128' } ] runs-on: windows-2022 @@ -70,6 +69,7 @@ jobs: uses: actions/checkout@v5 with: repository: huggingface/kernel-builder + ref: 158bffeb8eb0c8fe3bc66e9e2e1c669f56adbc87 # todo(mfuntowicz): remove this when merged in kernel-builder path: kernel-builder - name: Cache Rust build From fc4d4d642844f6f005ded2e14417b32c5334fdcf Mon Sep 17 00:00:00 2001 From: Morgan Funtowicz Date: Wed, 19 Nov 2025 11:49:16 +0100 Subject: [PATCH 21/22] misc(build-pr): update the fix revision to see? --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 8f8e8a2..7952824 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -69,7 +69,7 @@ jobs: uses: actions/checkout@v5 with: repository: huggingface/kernel-builder - ref: 158bffeb8eb0c8fe3bc66e9e2e1c669f56adbc87 # todo(mfuntowicz): remove this when merged in kernel-builder + ref: 3b6264e # todo(mfuntowicz): remove this when merged in kernel-builder path: kernel-builder - name: Cache Rust build From 70e1068f621fc889286896e1fb54aff67438dac5 Mon Sep 17 00:00:00 2001 From: Funtowicz Morgan Date: Wed, 19 Nov 2025 12:14:16 +0100 Subject: [PATCH 22/22] Change kernel-builder ref to specific commit Updated the reference for the kernel-builder repository to a specific commit. --- .github/workflows/build-pr-windows.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build-pr-windows.yaml b/.github/workflows/build-pr-windows.yaml index 7952824..2eb11e1 100644 --- a/.github/workflows/build-pr-windows.yaml +++ b/.github/workflows/build-pr-windows.yaml @@ -69,7 +69,7 @@ jobs: uses: actions/checkout@v5 with: repository: huggingface/kernel-builder - ref: 3b6264e # todo(mfuntowicz): remove this when merged in kernel-builder + ref: 3b6264ec69ef7d336ba7be6d86a137ef238f7e30 # todo(mfuntowicz): remove this when merged in kernel-builder path: kernel-builder - name: Cache Rust build