Change new kwarg name

Author: remi-or

src/transformers/generation/configuration_utils.py

@@ -755,7 +755,7 @@ def save_pretrained(
 
         output_config_file = os.path.join(save_directory, config_file_name)
 
-        self.to_json_file(output_config_file, use_diff=True, pop_keys=["compile_config"])
+        self.to_json_file(output_config_file, use_diff=True, keys_to_pop=["compile_config"])
         logger.info(f"Configuration saved in {output_config_file}")
 
         if push_to_hub:
@@ -1030,7 +1030,7 @@ def to_dict(self) -> dict[str, Any]:
         return output
 
     def to_json_string(
-        self, use_diff: bool = True, ignore_metadata: bool = False, pop_keys: list[str] | None = None
+        self, use_diff: bool = True, ignore_metadata: bool = False, keys_to_pop: list[str] | None = None
     ) -> str:
         """
         Serializes this instance to a JSON string.
@@ -1041,7 +1041,7 @@ def to_json_string(
                 is serialized to JSON string.
             ignore_metadata (`bool`, *optional*, defaults to `False`):
                 Whether to ignore the metadata fields present in the instance
-            pop_keys (`list[str]`, *optional*):
+            keys_to_pop (`list[str]`, *optional*):
                 Keys to pop from the config dictionary before serializing
 
         Returns:
@@ -1052,8 +1052,8 @@ def to_json_string(
         else:
             config_dict = self.to_dict()
 
-        if pop_keys is not None:
-            for key in pop_keys:
+        if keys_to_pop is not None:
+            for key in keys_to_pop:
                 config_dict.pop(key, None)
 
         if ignore_metadata:
@@ -1082,7 +1082,7 @@ def convert_dataclass_to_dict(obj):
         return json.dumps(config_dict, indent=2, sort_keys=True) + "\n"
 
     def to_json_file(
-        self, json_file_path: str | os.PathLike, use_diff: bool = True, pop_keys: list[str] | None = None
+        self, json_file_path: str | os.PathLike, use_diff: bool = True, keys_to_pop: list[str] | None = None
     ) -> None:
         """
         Save this instance to a JSON file.
@@ -1093,11 +1093,11 @@ def to_json_file(
             use_diff (`bool`, *optional*, defaults to `True`):
                 If set to `True`, only the difference between the config instance and the default `GenerationConfig()`
                 is serialized to JSON file.
-            pop_keys (`list[str]`, *optional*):
+            keys_to_pop (`list[str]`, *optional*):
                 Keys to pop from the config dictionary before serializing
         """
         with open(json_file_path, "w", encoding="utf-8") as writer:
-            writer.write(self.to_json_string(use_diff=use_diff, pop_keys=pop_keys))
+            writer.write(self.to_json_string(use_diff=use_diff, keys_to_pop=keys_to_pop))
 
     @classmethod
     def from_model_config(cls, model_config: PreTrainedConfig | dict) -> "GenerationConfig":