remove tokenizer warning #42483
Merged
remove tokenizer warning #42483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Nov 28, 2025
Collaborator
ArthurZucker
left a comment
ArthurZucker
left a comment
There was a problem hiding this comment.
feel free to remove it entirely its no longer valid
SunMarc
commented
Nov 28, 2025
| init_kwargs = json.load(tokenizer_config_handle) | ||
| # First attempt. We get tokenizer_class from tokenizer_config to check mismatch between tokenizers. | ||
| config_tokenizer_class = init_kwargs.get("tokenizer_class") | ||
| # used in the past to check if the tokenizer class matches the class in the repo | ||
| init_kwargs.pop("tokenizer_class", None) |
Member
Author
There was a problem hiding this comment.
left a small comment here to understand why we pop tokenizer_class. Maybe we don't even need to pop it ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes a warning that shouldn't appear in a specific case when calling AutoTokenizer.from_pretrained.
config_tokenizer_classandcls.__name__might not the same due to the alias we created.So
config_tokenizer_classends up beingPreTrainedTokenizerFastand when checking the class namecls.__name__we getTokenizersBackend.The warning is not needed anymore, so let's remove it entirely.
Reproduction
Warning: