feat: allow CP with trainer #42496
Open
feat: allow CP with trainer #42496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mehant Kammakomati <mehant.kammakomati2@ibm.com>
SunMarc
reviewed
Dec 1, 2025
Comment on lines
+2521
to
+2542
| cp_context = contextlib.nullcontext() | ||
| if self.accelerator.parallelism_config and self.accelerator.parallelism_config.cp_enabled: | ||
| cp_size_multiple = self.accelerator.parallelism_config.cp_size * 2 | ||
| max_length = ( | ||
| (inputs["input_ids"].shape[1] + (cp_size_multiple - 1)) // cp_size_multiple | ||
| ) * cp_size_multiple | ||
| inputs = self._pad_batch(inputs, max_length=max_length) | ||
| cp_context = self.accelerator.maybe_context_parallel( | ||
| buffers=[ | ||
| inputs["input_ids"], | ||
| inputs["shift_labels"], | ||
| inputs["labels"], | ||
| inputs["position_ids"], | ||
| ], | ||
| buffer_seq_dims=[1, 1, 1, 1], | ||
| no_restore_buffers={ | ||
| inputs["input_ids"], | ||
| inputs["shift_labels"], | ||
| inputs["labels"], | ||
| inputs["position_ids"], | ||
| }, | ||
| ) |
Member
There was a problem hiding this comment.
we have _prepare_context_parallel_inputs in training_step ! If things needs to be changed, it's better to do it there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?