Skip to content

Make 'Select File' label translatable #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barryceelen wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Make 'Select File' label translatable #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
faa7291
Make 'Select File' label translatable
barryceelen Aug 29, 2016
5efe115
Make 'Select Image’ label translatable
barryceelen Aug 29, 2016
776b2d1
Merge develop into file-field-string
barryceelen Jan 11, 2017
e6450bf
Merge develop
barryceelen Mar 24, 2017
74d5d4e
Re-add file field strings and script localization
barryceelen Mar 24, 2017
5c753b2
Add trailing comma to last line in array
barryceelen Mar 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions fields/class-cmb-file-field.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public function default_args() {
'text',
'application',
),
'string-select-file' => esc_html__( 'Select File', 'cmb' ),
)
);
}
Expand All @@ -48,6 +49,12 @@ function enqueue_scripts() {
wp_enqueue_media( array( 'post' => $post_ID ) );
wp_enqueue_script( 'cmb-file-upload', trailingslashit( CMB_URL ) . 'js/file-upload.js', array( 'jquery', 'cmb-scripts' ), CMB_VERSION );

wp_localize_script( 'cmb-file-upload', 'CMBFile', array(
'strings' => array(
'selectFile' => $this->args['string-select-file'],
),
) );

}

/**
Expand Down
1 change: 1 addition & 0 deletions fields/class-cmb-image-field.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ public function default_args() {
'image',
),
'show_size' => false,
'string-select-file' => esc_html__( 'Select Image', 'cmb' ),
)
);
}
Expand Down
2 changes: 1 addition & 1 deletion js/file-upload.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jQuery( document ).ready( function() {

var frameArgs = {
multiple: false,
title: 'Select File',
title: CMBFile.strings.selectFile
};

library = container.attr( 'data-type' ).split( ',' );
Expand Down