Skip to content

Commit 83bc2dc

Browse files
authored
[Reputation Oracle] refactor: move some types to separate files (#3319)
1 parent bf3b70d commit 83bc2dc

File tree

24 files changed

+73
-77
lines changed

24 files changed

+73
-77
lines changed

.github/workflows/ci-dependency-review.yaml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
name: Dependency Review
22
on:
3-
push:
4-
branches:
5-
- develop
6-
- main
73
pull_request:
84
branches:
95
- develop

packages/apps/reputation-oracle/server/src/common/errors/manifest.ts

Lines changed: 0 additions & 9 deletions
This file was deleted.

packages/apps/reputation-oracle/server/src/common/filters/exception.filter.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
HttpException,
77
} from '@nestjs/common';
88
import { Request, Response } from 'express';
9-
import { DatabaseError, isDuplicatedError } from '../errors/database';
9+
import { DatabaseError, isDuplicatedError } from '../../database';
1010
import logger from '../../logger';
1111
import { transformKeysFromCamelToSnake } from '../../utils/case-converters';
1212

packages/apps/reputation-oracle/server/src/database/base.repository.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { DataSource, EntityTarget, ObjectLiteral, Repository } from 'typeorm';
2-
import { DatabaseError, handleDbError } from '../common/errors/database';
2+
import { DatabaseError, handleDbError } from './errors';
33
import { BaseEntity } from './base.entity';
44

55
export class BaseRepository<

packages/apps/reputation-oracle/server/src/common/errors/database.ts renamed to packages/apps/reputation-oracle/server/src/database/errors.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { BaseError } from './base';
1+
import { BaseError } from '../common/errors/base';
22

3-
export enum PostgresErrorCodes {
3+
enum PostgresErrorCodes {
44
Duplicated = '23505',
55
}
66

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
11
export { BaseEntity } from './base.entity';
22
export { BaseRepository } from './base.repository';
33
export { DatabaseModule } from './database.module';
4+
export {
5+
DatabaseErrorMessages,
6+
DatabaseError,
7+
isDuplicatedError,
8+
} from './errors';

packages/apps/reputation-oracle/server/src/modules/abuse/abuse.service.spec.ts

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@ import {
1010
} from '@human-protocol/sdk';
1111
import { ConfigService } from '@nestjs/config';
1212
import { Test } from '@nestjs/testing';
13-
import {
14-
DatabaseError,
15-
DatabaseErrorMessages,
16-
} from '../../common/errors/database';
13+
import { DatabaseError, DatabaseErrorMessages } from '../../database';
1714
import { ServerConfigService } from '../../config';
1815
import { generateTestnetChainId } from '../web3/fixtures';
1916
import { Web3Service } from '../web3';

packages/apps/reputation-oracle/server/src/modules/abuse/abuse.service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import {
66
} from '@human-protocol/sdk';
77
import { Injectable } from '@nestjs/common';
88
import { ethers } from 'ethers';
9-
import { isDuplicatedError } from '../../common/errors/database';
9+
import { isDuplicatedError } from '../../database';
1010
import { ServerConfigService } from '../../config';
1111
import logger from '../../logger';
1212
import { Web3Service } from '../web3';

packages/apps/reputation-oracle/server/src/modules/auth/auth.service.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,7 @@ import {
4040
} from './auth.error';
4141
import { TokenEntity, TokenType } from './token.entity';
4242
import { TokenRepository } from './token.repository';
43-
44-
type AuthTokens = {
45-
accessToken: string;
46-
refreshToken: string;
47-
};
43+
import type { AuthTokens } from './types';
4844

4945
@Injectable()
5046
export class AuthService {
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
export type AuthTokens = {
2+
accessToken: string;
3+
refreshToken: string;
4+
};

0 commit comments

Comments
 (0)