-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Description
Dear Mustapha,
The current Smartg.run() method accepts a single atm (Atmosphere) and surf (Surface) object for the entire simulation. When running in batch mode (e.g., using le for multiple Solar Zenith Angles), all angles are simulated using this identical atmospheric profile.
For twilight simulations, atmospheric conditions (cloud cover, OD) change rapidly over the hours of the simulation window. Currently, accurately simulating this requires running Smartg.run() in a loop, which incurs significant overhead (kernel loading, memory transfer) for each step.
Proposed Solution
Allow atm (and potentially surf) to accept a list or array of objects corresponding to the batch dimension (e.g., NBTHETA or le['th']).
Example signature:
# current
m = Smartg().run(atm=single_atm, le={'th': [100, 101, 102]})
# proposed
atmos_list = [atm_at_4am, atm_at_430am, atm_at_5am]
m = Smartg().run(atm=atmos_list, le={'th': [100, 101, 102]})Metadata
Metadata
Assignees
Labels
No labels