Apply clippy fixes, except in #[test] code

Author: bossmc

.github/workflows/CI.yml

@@ -82,6 +82,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
+          components: clippy
           toolchain: ${{ matrix.rust }}
           override: true
 
@@ -91,6 +92,12 @@ jobs:
           command: test
           args: ${{ matrix.features }}
 
+      - name: Clippy
+        uses: actions-rs/cargo@v1
+        with:
+          command: clippy
+          args: ${{ matrix.features }} --lib --examples --benches
+
       - name: Test all benches
         if: matrix.benches
         uses: actions-rs/cargo@v1

benches/body.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "nightly")]
 #![feature(test)]
 #![deny(warnings)]
 

benches/connect.rs

@@ -1,8 +1,7 @@
+#![cfg(feature = "nightly")]
 #![feature(test)]
 #![deny(warnings)]
 
-extern crate test;
-
 // TODO: Reimplement http_connector bench using hyper::client::conn
 // (instead of removed HttpConnector).
 

benches/end_to_end.rs

@@ -1,8 +1,7 @@
+#![cfg(feature = "nightly")]
 #![feature(test)]
 #![deny(warnings)]
 
-extern crate test;
-
 // TODO: Reimplement Opts::bench using hyper::server::conn and hyper::client::conn
 // (instead of Server and HttpClient).
 

benches/pipeline.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "nightly")]
 #![feature(test)]
 #![deny(warnings)]
 

benches/server.rs

@@ -1,3 +1,4 @@
+#![cfg(feature = "nightly")]
 #![feature(test)]
 #![deny(warnings)]
 
@@ -149,7 +150,7 @@ fn raw_tcp_throughput_small_payload(b: &mut test::Bencher) {
 
         let mut buf = [0u8; 8192];
         while rx.try_recv().is_err() {
-            sock.read(&mut buf).unwrap();
+            let _ = sock.read(&mut buf).unwrap();
             sock.write_all(
                 b"\
                 HTTP/1.1 200 OK\r\n\
@@ -196,7 +197,7 @@ fn raw_tcp_throughput_large_payload(b: &mut test::Bencher) {
         let mut buf = [0u8; 8192];
         while rx.try_recv().is_err() {
             let r = sock.read(&mut buf).unwrap();
-            extern crate test;
+
             if r == 0 {
                 break;
             }

benches/support/tokiort.rs

@@ -32,13 +32,13 @@ impl Timer for TokioTimer {
     fn sleep(&self, duration: Duration) -> Box<dyn Sleep + Unpin> {
         let s = tokio::time::sleep(duration);
         let hs = TokioSleep { inner: Box::pin(s) };
-        return Box::new(hs);
+        Box::new(hs)
     }
 
     fn sleep_until(&self, deadline: Instant) -> Box<dyn Sleep + Unpin> {
-        return Box::new(TokioSleep {
+        Box::new(TokioSleep {
             inner: Box::pin(tokio::time::sleep_until(deadline.into())),
-        });
+        })
     }
 }
 

examples/client.rs

@@ -65,7 +65,7 @@ async fn fetch_url(url: hyper::Uri) -> Result<()> {
     while let Some(next) = res.frame().await {
         let frame = next?;
         if let Some(chunk) = frame.data_ref() {
-            io::stdout().write_all(&chunk).await?;
+            io::stdout().write_all(chunk).await?;
         }
     }
 

examples/gateway.rs

@@ -11,8 +11,6 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
     let in_addr: SocketAddr = ([127, 0, 0, 1], 3001).into();
     let out_addr: SocketAddr = ([127, 0, 0, 1], 3000).into();
 
-    let out_addr_clone = out_addr.clone();
-
     let listener = TcpListener::bind(in_addr).await?;
 
     println!("Listening on http://{}", in_addr);
@@ -27,7 +25,7 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         let service = service_fn(move |mut req| {
             let uri_string = format!(
                 "http://{}{}",
-                out_addr_clone,
+                out_addr,
                 req.uri()
                     .path_and_query()
                     .map(|x| x.as_str())

examples/http_proxy.rs

@@ -104,7 +104,7 @@ async fn proxy(req: Request<Recv>) -> Result<Response<BoxBody<Bytes, hyper::Erro
 }
 
 fn host_addr(uri: &http::Uri) -> Option<String> {
-    uri.authority().and_then(|auth| Some(auth.to_string()))
+    uri.authority().map(|auth| auth.to_string())
 }
 
 fn empty() -> BoxBody<Bytes, hyper::Error> {