Combine required/dependentRequired messages

[jdesrosiers]

The required and dependentRequired error handlers use the same message. That can result in what looks like duplicate messages.

{
  "allOf": [
    { "required": ["foo"] },
    { "required": ["foo", "bar"] },
    {
      "dependentRequired": {
        "a": ["b"]
      }
    }
  ]
}

This can result in multiple similar and sometimes redundant messages

• Missing required property: foo
• Missing required properties: foo and bar
• Missing required property: b

This can be collapsed into a single message

• Missing required properties: foo, bar, and b

The required and dependentRequired keywords will need to be combined into a single error handler. I think we can even combine dependencies, or at least part of it into that combined handler.

[ShivaGupta-14]

I would like to work on this issue

My Understanding

When jsonSchemaErrors() is called, it invokes getErrors(), which iterates over each instance location in normalizedErrors, for each location, all registered error handlers are run; each handler checks for its keyword, processes the related errors, and returns error objects, all results are collected and returned as the final user-friendly errors

Currently, requiredErrorHandler and dependentRequiredErrorHandler are separate handlers when both keywords fail, each produces its own error messages independently, this results in multiple similar messages as shown in issue

Proposed Solution

A combined error handler required-all.js that handles both required and dependentRequired keywords in a single handler. Instead of registering two separate handlers, we register this one combined handler.

How It Works

1. Loops through all failed required keyword locations and collects missing properties into a Set
2. Loops through all failed dependentRequired keyword locations and adds those missing properties to the same Set
3. The Set automatically deduplicates property names (e.g., "foo" appearing in multiple required
4. Returns a single error object with all missing properties combined

This produces one consolidated message: "Missing required properties: foo, bar, and b"

[jdesrosiers]

@ShivaGupta-14 I realized this needs to be put on hold until #130 is merged because we'll also need to include dependencies in this handler. Also, the complexities of dependencies might not make this a good first issue. So, maybe pick another issue for now. There are a lot available at the moment.

[ShivaGupta-14]

@jdesrosiers got it, thanks for the explanation, I’ll pick another issue for now and revisit this once #130 is merged

[jdesrosiers]

@ShivaGupta-14, this is unblocked. Do you want to do this one next?

[jdesrosiers]

@ShivaGupta-14, nevermind, I already have you assigned to another issue. We'll leave this available for now.

[ShivaGupta-14]

@jdesrosiers I am happy to take this issue, the previous one is almost complete :)

[Sam-61s]

Hi @jdesrosiers,
I’m available now and happy to take this issue.
I plan to combine required and dependentRequired failures into a single handler and return one consolidated message for missing properties.
Please let me know if you’re okay assigning this to me.

[jdesrosiers]

@Sam-61s Go ahead with this one.

[Sam-61s]

Thanks.. I’ll get started on this