chore: Added spotless and explicit toString() impls (#33)

Author: singhalprerana

build.gradle.kts

@@ -6,6 +6,7 @@ plugins {
   id("org.hypertrace.ci-utils-plugin") version "0.3.0"
   id("org.hypertrace.publish-plugin") version "1.0.2" apply false
   id("org.hypertrace.jacoco-report-plugin") version "0.2.0" apply false
+  id("org.hypertrace.code-style-plugin") version "1.1.2" apply false
 }
 
 subprojects {
@@ -22,4 +23,6 @@ subprojects {
       targetCompatibility = JavaVersion.VERSION_11
     }
   }
+
+  apply(plugin = "org.hypertrace.code-style-plugin")
 }

grpc-client-rx-utils/src/main/java/org/hypertrace/core/grpcutils/client/rx/GrpcRxExecutionContext.java

@@ -18,14 +18,10 @@ public interface GrpcRxExecutionContext {
    */
   <TResp> Single<TResp> call(Callable<TResp> callable);
 
-  /**
-   * Creates the provided single in this execution context, returning the result.
-   */
+  /** Creates the provided single in this execution context, returning the result. */
   <TResp> Single<TResp> wrapSingle(Supplier<Single<TResp>> singleSupplier);
 
-  /**
-   * Creates the provided maybe in this execution context, returning the result.
-   */
+  /** Creates the provided maybe in this execution context, returning the result. */
   <TResp> Maybe<TResp> wrapMaybe(Supplier<Maybe<TResp>> maybeSupplier);
 
   /**

grpc-client-rx-utils/src/main/java/org/hypertrace/core/grpcutils/client/rx/StreamingClientResponseObserver.java

@@ -6,10 +6,12 @@
 
 /**
  * Adapter class for bridging from a GRPC stream to an Rx Observable.
+ *
  * @param <ReqT>
  * @param <RespT>
  */
-public class StreamingClientResponseObserver<ReqT, RespT> implements ClientResponseObserver<ReqT, RespT> {
+public class StreamingClientResponseObserver<ReqT, RespT>
+    implements ClientResponseObserver<ReqT, RespT> {
 
   private final ObservableEmitter<RespT> emitter;
   private ClientCallStreamObserver<ReqT> requestStream;
@@ -18,7 +20,7 @@ public class StreamingClientResponseObserver<ReqT, RespT> implements ClientRespo
     this.emitter = emitter;
     this.emitter.setCancellable(
         () ->
-             this.requestStream.cancel(
+            this.requestStream.cancel(
                 "StreamingClientResponseObserver cancelling after emitter disposed", null));
   }
 

grpc-client-utils/README.md

@@ -2,4 +2,4 @@
 ###### org.hypertrace.core.grpcutils:grpc-client-utils
 
 This module contains some common classes that are used across all the Platform
-GRPC clients. 
+GRPC clients.

grpc-client-utils/src/main/java/org/hypertrace/core/grpcutils/client/ContextKeyBasedCreds.java

@@ -13,8 +13,8 @@ public ContextKeyBasedCreds(Context.Key<RequestContext> contextKey) {
   }
 
   @Override
-  public void applyRequestMetadata(RequestInfo requestInfo, Executor appExecutor,
-                                   MetadataApplier applier) {
+  public void applyRequestMetadata(
+      RequestInfo requestInfo, Executor appExecutor, MetadataApplier applier) {
     try {
       applyRequestContext(applier, contextKey.get());
     } catch (RuntimeException e) {

grpc-client-utils/src/main/java/org/hypertrace/core/grpcutils/client/RequestContextAsCreds.java

@@ -1,5 +1,8 @@
 package org.hypertrace.core.grpcutils.client;
 
+import static io.grpc.Metadata.ASCII_STRING_MARSHALLER;
+import static io.grpc.Metadata.BINARY_BYTE_MARSHALLER;
+
 import io.grpc.CallCredentials;
 import io.grpc.Metadata;
 import io.grpc.Status;
@@ -8,20 +11,16 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import static io.grpc.Metadata.ASCII_STRING_MARSHALLER;
-import static io.grpc.Metadata.BINARY_BYTE_MARSHALLER;
-
 public abstract class RequestContextAsCreds extends CallCredentials {
   private static Logger LOGGER = LoggerFactory.getLogger(RequestContextAsCreds.class);
 
   @Override
-  public void thisUsesUnstableApi() {
-  }
+  public void thisUsesUnstableApi() {}
 
   /**
-   * Adds the request headers in the request context to a Metadata object to be propagated in the client call. All the
-   * headers are propagated so if any headers should be exempted from propagation, that should be handled separately
-   * before this call is made.
+   * Adds the request headers in the request context to a Metadata object to be propagated in the
+   * client call. All the headers are propagated so if any headers should be exempted from
+   * propagation, that should be handled separately before this call is made.
    *
    * @param applier
    * @param requestContext
@@ -34,9 +33,12 @@ protected void applyRequestContext(MetadataApplier applier, RequestContext reque
         if (entry.getValue() != null) {
           String key = entry.getKey();
           if (key.toLowerCase().endsWith(Metadata.BINARY_HEADER_SUFFIX)) {
-            metadata.put(Metadata.Key.of(entry.getKey(), BINARY_BYTE_MARSHALLER), entry.getValue().getBytes());
+            metadata.put(
+                Metadata.Key.of(entry.getKey(), BINARY_BYTE_MARSHALLER),
+                entry.getValue().getBytes());
           } else {
-            metadata.put(Metadata.Key.of(entry.getKey(), ASCII_STRING_MARSHALLER), entry.getValue());
+            metadata.put(
+                Metadata.Key.of(entry.getKey(), ASCII_STRING_MARSHALLER), entry.getValue());
           }
         }
       }

grpc-client-utils/src/main/java/org/hypertrace/core/grpcutils/client/RequestContextClientCallCredsProviderFactory.java

@@ -4,7 +4,8 @@
 import org.hypertrace.core.grpcutils.context.RequestContext;
 
 public class RequestContextClientCallCredsProviderFactory {
-  private static class DefaultRequestContextClientCallCredsProvider implements ClientCallCredentialsProvider {
+  private static class DefaultRequestContextClientCallCredsProvider
+      implements ClientCallCredentialsProvider {
     private final ContextKeyBasedCreds credsProvider;
 
     public DefaultRequestContextClientCallCredsProvider() {

grpc-client-utils/src/test/java/org/hypertrace/core/grpcutils/client/ContextKeyBasedCredsTest.java

@@ -1,5 +1,7 @@
 package org.hypertrace.core.grpcutils.client;
 
+import static org.mockito.Mockito.mock;
+
 import io.grpc.CallCredentials;
 import io.grpc.Context;
 import io.grpc.Metadata;
@@ -12,16 +14,14 @@
 import org.junit.jupiter.api.Assertions;
 import org.junit.jupiter.api.Test;
 
-import static io.grpc.Metadata.BINARY_BYTE_MARSHALLER;
-import static org.mockito.Mockito.mock;
-
 public class ContextKeyBasedCredsTest {
   private static final String TENANT_ID = "test-tenant-id";
   private static final String TEST_AUTH_HEADER = "test-auth-header";
 
   @Test
   public void testApplyRequestMetadata_shouldApplyAllHeaders() {
-    CallCredentials callCredentials = RequestContextClientCallCredsProviderFactory.getClientCallCredsProvider().get();
+    CallCredentials callCredentials =
+        RequestContextClientCallCredsProviderFactory.getClientCallCredsProvider().get();
 
     Assertions.assertTrue(callCredentials instanceof ContextKeyBasedCreds);
 
@@ -32,45 +32,57 @@ public void testApplyRequestMetadata_shouldApplyAllHeaders() {
     requestContext.add("x-some-tenant-header", "v1");
     requestContext.add("grpc-trace-bin", "AAARf5ZpQwlN/8FVe1axOPlaAQIdRU/Y8j0LAgE");
 
-
     Context ctx = Context.current().withValue(RequestContext.CURRENT, requestContext);
 
     Context previous = ctx.attach();
     try {
-      callCredentials.applyRequestMetadata(mock(CallCredentials.RequestInfo.class), mock(Executor.class), new CallCredentials.MetadataApplier() {
-        @Override
-        public void apply(Metadata headers) {
-          Map<String, String> headersMap = headers.keys().stream()
-              .collect(Collectors.toUnmodifiableMap(k -> k, k -> {
-                String value;
-                if (k.toLowerCase().endsWith(Metadata.BINARY_HEADER_SUFFIX)) {
-                  value = new String(headers.get(Metadata.Key.of(k, Metadata.BINARY_BYTE_MARSHALLER)));
-                } else {
-                  value = headers.get(Metadata.Key.of(k, Metadata.ASCII_STRING_MARSHALLER));
-                }
-                return value;
-              } ));
+      callCredentials.applyRequestMetadata(
+          mock(CallCredentials.RequestInfo.class),
+          mock(Executor.class),
+          new CallCredentials.MetadataApplier() {
+            @Override
+            public void apply(Metadata headers) {
+              Map<String, String> headersMap =
+                  headers.keys().stream()
+                      .collect(
+                          Collectors.toUnmodifiableMap(
+                              k -> k,
+                              k -> {
+                                String value;
+                                if (k.toLowerCase().endsWith(Metadata.BINARY_HEADER_SUFFIX)) {
+                                  value =
+                                      new String(
+                                          headers.get(
+                                              Metadata.Key.of(k, Metadata.BINARY_BYTE_MARSHALLER)));
+                                } else {
+                                  value =
+                                      headers.get(
+                                          Metadata.Key.of(k, Metadata.ASCII_STRING_MARSHALLER));
+                                }
+                                return value;
+                              }));
 
-          // Should filter out the TENANT_ID_HEADER_KEY
-          Assertions.assertEquals(
-              Map.of(
-                  RequestContextConstants.TENANT_ID_HEADER_KEY, TENANT_ID,
-                  RequestContextConstants.AUTHORIZATION_HEADER, TEST_AUTH_HEADER,
-                  "x-some-tenant-header", "v1",
-                  "grpc-trace-bin", "AAARf5ZpQwlN/8FVe1axOPlaAQIdRU/Y8j0LAgE"
-              ),
-              headersMap);
-        }
+              // Should filter out the TENANT_ID_HEADER_KEY
+              Assertions.assertEquals(
+                  Map.of(
+                      RequestContextConstants.TENANT_ID_HEADER_KEY,
+                      TENANT_ID,
+                      RequestContextConstants.AUTHORIZATION_HEADER,
+                      TEST_AUTH_HEADER,
+                      "x-some-tenant-header",
+                      "v1",
+                      "grpc-trace-bin",
+                      "AAARf5ZpQwlN/8FVe1axOPlaAQIdRU/Y8j0LAgE"),
+                  headersMap);
+            }
 
-        @Override
-        public void fail(Status status) {
-          Assertions.fail("Failed in CallCredentials.MetadataApplier");
-        }
-      });
+            @Override
+            public void fail(Status status) {
+              Assertions.fail("Failed in CallCredentials.MetadataApplier");
+            }
+          });
     } finally {
       ctx.detach(previous);
     }
   }
-
-
 }

grpc-client-utils/src/test/java/org/hypertrace/core/grpcutils/client/GrpcChannelRegistryTest.java

@@ -16,7 +16,6 @@
 import io.grpc.Deadline.Ticker;
 import io.grpc.ManagedChannel;
 import io.grpc.ManagedChannelBuilder;
-import java.util.Map;
 import java.util.concurrent.TimeUnit;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;