Skip to content

Commit 2dc1153

Browse files
vidarlGrabowskiM
andcommitted
Apply suggestions from code review
Co-authored-by: Michał Grabowski <michal.grabowski@ibexa.co>
1 parent 2b9f002 commit 2dc1153

File tree

1 file changed

+15
-10
lines changed

1 file changed

+15
-10
lines changed

src/bundle/Resources/public/js/scripts/core/date.time.picker.js

Lines changed: 15 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ class DateTimePicker {
104104
}
105105
}
106106

107-
onKeyUp(isHour, isMinute, isSecond, event) {
107+
onKeyUp(type, event) {
108108
const inputValue = event.target.value;
109109

110110
if (inputValue.length === 0) {
@@ -120,12 +120,17 @@ class DateTimePicker {
120120
return;
121121
}
122122

123-
if (isHour) {
124-
flatpickrDate.setHours(value);
125-
} else if (isMinute) {
126-
flatpickrDate.setMinutes(value);
127-
} else if (isSecond) {
128-
flatpickrDate.setSeconds(value);
123+
switch (type) {
124+
case 'hours':
125+
flatpickrDate.setHours(value);
126+
break;
127+
case 'minutes':
128+
flatpickrDate.setMinutes(value);
129+
break;
130+
case 'seconds':
131+
flatpickrDate.setSeconds(value);
132+
break;
133+
}
129134
}
130135

131136
if (this.flatpickrInstance.config.minDate?.getTime() > flatpickrDate.getTime()) {
@@ -152,9 +157,9 @@ class DateTimePicker {
152157
);
153158

154159
if (this.flatpickrInstance.config.enableTime) {
155-
this.flatpickrInstance.hourElement.addEventListener('keyup', this.onKeyUp.bind(this, true, false, false), false);
156-
this.flatpickrInstance.minuteElement.addEventListener('keyup', this.onKeyUp.bind(this, false, true, false), false);
157-
this.flatpickrInstance.secondElement.addEventListener('keyup', this.onKeyUp.bind(this, false, false, true), false);
160+
this.flatpickrInstance.hourElement.addEventListener('keyup', this.onKeyUp.bind(this, 'hours'), false);
161+
this.flatpickrInstance.minuteElement.addEventListener('keyup', this.onKeyUp.bind(this, 'minutes'), false);
162+
this.flatpickrInstance.secondElement.addEventListener('keyup', this.onKeyUp.bind(this, 'seconds'), false);
158163
}
159164
}
160165
}

0 commit comments

Comments
 (0)