Fixing some more code smells

Author: sebastian-peter

src/main/java/edu/ie3/datamodel/io/connectors/CsvFileConnector.java

@@ -180,11 +180,8 @@ public BufferedReader initReader(Class<? extends UniqueEntity> clz)
                               + "'."));
       return initReader(filePath);
     } catch (ConnectorException e) {
-      log.error(
-          "Cannot get reader for entity '{}' as no file naming strategy for this file exists. Exception: {}",
-          clz.getSimpleName(),
-          e);
-      throw e;
+      throw new ConnectorException(
+          "Cannot initialize reader for entity '" + clz.getSimpleName() + "'.", e);
     }
   }
 

src/main/java/edu/ie3/datamodel/io/naming/FileNamingStrategy.java

@@ -100,7 +100,7 @@ Optional<Path> getFilePath(T timeSeries) {
    * @return Concatenation of sub directory structure and file name
    * @deprecated replaced with {@link FileUtils#of(String, Optional)}
    */
-  @Deprecated
+  @Deprecated(since = "3.0", forRemoval = true)
   private Optional<Path> getFilePath(String fileName, Optional<Path> subDirectories) {
     if (fileName.isEmpty()) return Optional.empty();
     return subDirectories

src/main/java/edu/ie3/datamodel/utils/FileUtils.java

@@ -16,10 +16,10 @@
 
 /** Some utility functionalities. */
 public class FileUtils {
-  public static final Pattern FILE_NAME_PATTERN =
+  private static final Pattern FILE_NAME_PATTERN =
       Pattern.compile(
           "^(?<fileName>[^\\\\/\\s.]{0,255})(?:\\.(?<extension>[a-zA-Z0-9]{0,10}(?:\\.[a-zA-Z0-9]{0,10})?))?$");
-  public static final String CSV_FILE_EXTENSION = "csv";
+  private static final String CSV_FILE_EXTENSION = "csv";
 
   private FileUtils() {
     throw new IllegalStateException("Utility classes cannot be instantiated");