Throw exception when failing to build coordinate

Author: t-ober

CHANGELOG.md

@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased/Snapshot]
 
+### Added
+
+### Fixed
+
+### Changed
+- `SqlIdCoordinateSource.createCooridinateValue` now throws an exception when the coordinate can not be built [#911](https://github.com/ie3-institute/PowerSystemDataModel/issues/911)
+
 ## [4.0.0] - 2023-08-01
 
 ### Added

src/main/java/edu/ie3/datamodel/io/source/sql/SqlIdCoordinateSource.java

@@ -173,27 +173,18 @@ public List<CoordinateDistance> getClosestCoordinates(
 
   // -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
 
-  private Optional<CoordinateValue> createCoordinateValue(Map<String, String> fieldToValues) {
+  private CoordinateValue createCoordinateValue(Map<String, String> fieldToValues) {
     fieldToValues.remove("distance");
 
     SimpleFactoryData simpleFactoryData = new SimpleFactoryData(fieldToValues, Pair.class);
-    Optional<Pair<Integer, Point>> pair = factory.get(simpleFactoryData).getData();
 
-    if (pair.isEmpty()) {
-      return Optional.empty();
-    } else {
-      Pair<Integer, Point> data = pair.get();
-      return Optional.of(new CoordinateValue(data.getKey(), data.getValue()));
-    }
+    Pair<Integer, Point> pair = factory.get(simpleFactoryData).getOrThrow();
+    return new CoordinateValue(pair.getKey(), pair.getValue());
   }
 
   private List<CoordinateValue> executeQueryToList(
       String query, SqlDataSource.AddParams addParams) {
-    return dataSource
-        .executeQuery(query, addParams)
-        .map(this::createCoordinateValue)
-        .flatMap(Optional::stream)
-        .toList();
+    return dataSource.executeQuery(query, addParams).map(this::createCoordinateValue).toList();
   }
 
   /**