Skip to content

Commit 15babbd

Browse files
committed
try not to leak resources in CsvDataSource
1 parent 0036919 commit 15babbd

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

src/main/java/edu/ie3/datamodel/io/source/csv/CsvDataSource.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -356,11 +356,16 @@ protected <T extends UniqueEntity> Optional<T> findFirstEntityByUuid(
356356
*/
357357
protected Stream<Map<String, String>> buildStreamWithFieldsToAttributesMap(
358358
Class<? extends UniqueEntity> entityClass, CsvFileConnector connector) {
359-
try {
360-
return buildStreamWithFieldsToAttributesMap(entityClass, connector.initReader(entityClass));
359+
try (BufferedReader reader = connector.initReader(entityClass)) {
360+
return buildStreamWithFieldsToAttributesMap(entityClass, reader);
361361
} catch (FileNotFoundException e) {
362362
log.warn(
363363
"Unable to find file for entity '{}': {}", entityClass.getSimpleName(), e.getMessage());
364+
} catch (IOException e) {
365+
log.warn(
366+
"Unable to close stream from file for entity '{}': {}",
367+
entityClass.getSimpleName(),
368+
e.getMessage());
364369
}
365370

366371
return Stream.empty();

0 commit comments

Comments
 (0)