Skip to content

Commit 1acebf2

Browse files
Merge pull request #706 from ie3-institute/sp/#705-double-converters-psu
Adapted to new double converters in PSU
2 parents 80d5e1e + 9afeacb commit 1acebf2

File tree

4 files changed

+12
-14
lines changed

4 files changed

+12
-14
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
7171
- Force user to provide time stamp pattern to `CouchbaseWeatherSource` to ensure harmonized querying
7272
- BREAKING: Updating PowerSystemUtils dependency to 2.0-SNAPSHOT [#595](https://github.com/ie3-institute/PowerSystemDataModel/issues/595)
7373
- BREAKING: Generified the `LoadInput` attribute `standardLoadProfile` to `loadProfile` as it should also address the newly added `TemperatureDependantLoadProfile`s [#601](https://github.com/ie3-institute/PowerSystemDataModel/issues/601)
74+
- Adapted to new double converters in PSU [#705](https://github.com/ie3-institute/PowerSystemDataModel/issues/705)
7475

7576
## [2.1.0] - 2022-01-05
7677

src/main/java/edu/ie3/datamodel/models/StandardUnits.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import static edu.ie3.util.quantities.PowerSystemUnits.*;
99

1010
import edu.ie3.util.quantities.interfaces.*;
11-
import javax.measure.MetricPrefix;
1211
import javax.measure.Unit;
1312
import javax.measure.quantity.*;
1413

@@ -31,7 +30,7 @@ public class StandardUnits {
3130
/** Energy for input purposes in kWh */
3231
public static final Unit<Energy> ENERGY_IN = KILOWATTHOUR;
3332
/** Energy for result purposes in MWh */
34-
public static final Unit<Energy> ENERGY_RESULT = MetricPrefix.MEGA(WATTHOUR);
33+
public static final Unit<Energy> ENERGY_RESULT = MEGAWATTHOUR;
3534
/** Rated voltage magnitude (mainly for input purposes) in kV */
3635
public static final Unit<ElectricPotential> RATED_VOLTAGE_MAGNITUDE = KILOVOLT;
3736
/** Magnitude of an electric current in A */
@@ -51,11 +50,11 @@ public class StandardUnits {
5150
/** Reactance per length (mainly for lines) in Ω/km */
5251
public static final Unit<SpecificResistance> REACTANCE_PER_LENGTH = OHM_PER_KILOMETRE;
5352
/** Admittance in nS */
54-
public static final Unit<ElectricConductance> CONDUCTANCE = MetricPrefix.NANO(SIEMENS);
53+
public static final Unit<ElectricConductance> CONDUCTANCE = NANOSIEMENS;
5554
/** Conductance in nS */
56-
public static final Unit<ElectricConductance> SUSCEPTANCE = MetricPrefix.NANO(SIEMENS);
55+
public static final Unit<ElectricConductance> SUSCEPTANCE = NANOSIEMENS;
5756
/** Susceptance in nS */
58-
public static final Unit<ElectricConductance> ADMITTANCE = MetricPrefix.NANO(SIEMENS);
57+
public static final Unit<ElectricConductance> ADMITTANCE = NANOSIEMENS;
5958
/** Admittance per length (mainly for lines) in µS/km */
6059
public static final Unit<SpecificConductance> ADMITTANCE_PER_LENGTH = MICRO_SIEMENS_PER_KILOMETRE;
6160
/** Conductance per length (mainly for lines) in µS/km */

src/test/groovy/edu/ie3/datamodel/utils/validation/ValidationUtilsTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ class ValidationUtilsTest extends Specification {
171171

172172
then:
173173
InvalidEntityException ex = thrown()
174-
ex.message == "Entity is invalid because of: The following quantities have to be zero or positive: -1 μS/km [LineTypeInput{uuid=3bed3eb3-9790-4874-89b5-a5434d408088, id=lineType_AtoB, b=-1 μS/km, g=0 μS/km, r=0.437 Ω/km, x=0.356 Ω/km, iMax=300 A, vRated=20 kV}]"
174+
ex.message == "Entity is invalid because of: The following quantities have to be zero or positive: -1 µS/km [LineTypeInput{uuid=3bed3eb3-9790-4874-89b5-a5434d408088, id=lineType_AtoB, b=-1 µS/km, g=0 µS/km, r=0.437 Ω/km, x=0.356 Ω/km, iMax=300 A, vRated=20 kV}]"
175175
}
176176

177177
def "The check for zero or negative entities should work as expected"() {
@@ -208,7 +208,7 @@ class ValidationUtilsTest extends Specification {
208208

209209
then:
210210
InvalidEntityException ex = thrown()
211-
ex.message == "Entity is invalid because of: The following quantities have to be positive: 0 μS/km [LineTypeInput{uuid=3bed3eb3-9790-4874-89b5-a5434d408088, id=lineType_AtoB, b=0 μS/km, g=0 μS/km, r=0.437 Ω/km, x=0.356 Ω/km, iMax=300 A, vRated=20 kV}]"
211+
ex.message == "Entity is invalid because of: The following quantities have to be positive: 0 µS/km [LineTypeInput{uuid=3bed3eb3-9790-4874-89b5-a5434d408088, id=lineType_AtoB, b=0 µS/km, g=0 µS/km, r=0.437 Ω/km, x=0.356 Ω/km, iMax=300 A, vRated=20 kV}]"
212212
}
213213

214214
def "Checking an unsupported asset leads to an exception"() {

src/test/groovy/edu/ie3/test/common/SampleJointGrid.groovy

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -23,13 +23,11 @@ import edu.ie3.datamodel.models.input.system.StorageInput
2323
import edu.ie3.datamodel.models.input.system.characteristic.OlmCharacteristicInput
2424
import edu.ie3.datamodel.models.voltagelevels.GermanVoltageLevelUtils
2525
import edu.ie3.datamodel.utils.GridAndGeoUtils
26-
import edu.ie3.util.quantities.PowerSystemUnits
2726
import org.locationtech.jts.geom.Point
2827
import org.locationtech.jts.io.ParseException
2928
import org.locationtech.jts.io.geojson.GeoJsonReader
3029
import tech.units.indriya.quantity.Quantities
3130

32-
import javax.measure.MetricPrefix
3331
import java.util.stream.Collectors
3432

3533
import static edu.ie3.util.quantities.PowerSystemUnits.*
@@ -249,7 +247,7 @@ class SampleJointGrid extends SystemParticipantTestData {
249247
"nodeD",
250248
OperatorInput.NO_OPERATOR_ASSIGNED,
251249
OperationTime.notLimited(),
252-
Quantities.getQuantity(1, PowerSystemUnits.PU),
250+
Quantities.getQuantity(1, PU),
253251
false,
254252
(Point) geoJsonReader.read(
255253
"{ \"type\": \"Point\", \"coordinates\": [6.592276813887139, 49.37770599548332] }"),
@@ -359,8 +357,8 @@ class SampleJointGrid extends SystemParticipantTestData {
359357
Quantities.getQuantity(630d, KILOVOLTAMPERE),
360358
Quantities.getQuantity(10d, KILOVOLT),
361359
Quantities.getQuantity(0.4, KILOVOLT),
362-
Quantities.getQuantity(0d, MetricPrefix.MICRO(SIEMENS)),
363-
Quantities.getQuantity(0d, MetricPrefix.MICRO(SIEMENS)),
360+
Quantities.getQuantity(0d, MICROSIEMENS),
361+
Quantities.getQuantity(0d, MICROSIEMENS),
364362
Quantities.getQuantity(0.5, PERCENT),
365363
Quantities.getQuantity(0d, DEGREE_GEOM),
366364
false,
@@ -390,8 +388,8 @@ class SampleJointGrid extends SystemParticipantTestData {
390388
Quantities.getQuantity(800d, KILOVOLTAMPERE),
391389
Quantities.getQuantity(110d, KILOVOLT),
392390
Quantities.getQuantity(10d, KILOVOLT),
393-
Quantities.getQuantity(0d, MetricPrefix.MICRO(SIEMENS)),
394-
Quantities.getQuantity(0d, MetricPrefix.MICRO(SIEMENS)),
391+
Quantities.getQuantity(0d, MICROSIEMENS),
392+
Quantities.getQuantity(0d, MICROSIEMENS),
395393
Quantities.getQuantity(0.5, PERCENT),
396394
Quantities.getQuantity(0d, DEGREE_GEOM),
397395
false,

0 commit comments

Comments
 (0)