Skip to content

Commit 6edd3e6

Browse files
Merge pull request #1024 from ie3-institute/jb/#1022-fix-csvgraphicsource-test
Fix CsvGraphicSource testing
2 parents 21eaef3 + 0e81ccc commit 6edd3e6

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2121
- Fixed thermal-house-documentation [#873](https://github.com/ie3-institute/PowerSystemDataModel/issues/873)
2222
- Fixed ElectricVehicle Documentation [#875](https://github.com/ie3-institute/PowerSystemDataModel/issues/875)
2323
- Fixed Equal behavior of `ConnectorResult` [#1001](https://github.com/ie3-institute/PowerSystemDataModel/issues/1001)
24+
- Fixed test for invalid input data in `CsvGraphicSource` [#1022](https://github.com/ie3-institute/PowerSystemDataModel/issues/1022)
2425

2526
### Changed
2627
- Changing from comparing strings to comparing uuids in `EntitySource.findFirstEntityByUuid` [#829](https://github.com/ie3-institute/PowerSystemDataModel/issues/829)

src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvGraphicSourceTest.groovy

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,15 @@ package edu.ie3.datamodel.io.source.csv
88
import static edu.ie3.test.helper.EntityMap.map
99

1010
import edu.ie3.datamodel.exceptions.FailureException
11+
import edu.ie3.datamodel.exceptions.GraphicSourceException
1112
import edu.ie3.datamodel.exceptions.SourceException
1213
import edu.ie3.datamodel.io.source.GraphicSource
1314
import edu.ie3.datamodel.io.source.RawGridSource
1415
import edu.ie3.datamodel.io.source.TypeSource
1516
import edu.ie3.datamodel.models.input.NodeInput
1617
import edu.ie3.datamodel.models.input.OperatorInput
1718
import edu.ie3.datamodel.models.input.connector.LineInput
19+
import edu.ie3.datamodel.models.input.connector.type.LineTypeInput
1820
import edu.ie3.datamodel.models.input.graphics.NodeGraphicInput
1921
import edu.ie3.datamodel.utils.Try
2022
import edu.ie3.test.common.GridTestData as gtd
@@ -45,28 +47,31 @@ class CsvGraphicSourceTest extends Specification implements CsvTestDataMeta {
4547
def rawGridSource =
4648
new RawGridSource(typeSource, new CsvDataSource(csvSep, gridDefaultFolderPath, fileNamingStrategy)) {
4749
@Override
48-
Map<UUID, NodeInput> getNodes() {
50+
Map<UUID, LineInput> getLines() {
4951
return Collections.emptyMap()
5052
}
5153

5254
@Override
53-
Map<UUID, NodeInput> getNodes(Map<UUID, OperatorInput> operators) {
55+
Map<UUID, LineInput> getLines(
56+
Map<UUID, OperatorInput> operators,
57+
Map<UUID, NodeInput> nodes,
58+
Map<UUID, LineTypeInput> lineTypeInputs) {
5459
return Collections.emptyMap()
5560
}
5661
}
5762

5863
def graphicSource = new GraphicSource(typeSource, rawGridSource, new CsvDataSource(csvSep, graphicsFolderPath, fileNamingStrategy))
5964

6065
when:
61-
def graphicElements = Try.of(() -> graphicSource.graphicElements, SourceException)
66+
def graphicElements = Try.of(() -> graphicSource.graphicElements, GraphicSourceException)
6267

6368
then:
6469
graphicElements.failure
6570
graphicElements.data == Optional.empty()
6671

6772
Exception ex = graphicElements.exception.get()
68-
ex.class == SourceException
69-
ex.message.startsWith("edu.ie3.datamodel.exceptions.FailureException: 2 exception(s) occurred within \"LineInput\" data, one is: edu.ie3.datamodel.exceptions.FactoryException: edu.ie3.datamodel.exceptions.SourceException: Linked nodeA with UUID 4ca90220-74c2-4369-9afa-a18bf068840d was not found for entity")
73+
ex.class == GraphicSourceException
74+
ex.message.startsWith("1error(s) occurred while initializing graphic elements. edu.ie3.datamodel.exceptions.FailureException: 1 exception(s) occurred within \"LineGraphicInput\" data, one is: edu.ie3.datamodel.exceptions.FactoryException: edu.ie3.datamodel.exceptions.SourceException: Linked line with UUID 91ec3bcf-1777-4d38-af67-0bf7c9fa73c7 was not found for entity")
7075
}
7176

7277

0 commit comments

Comments
 (0)