Sonarqube

Author: jo-bao

src/main/java/edu/ie3/datamodel/io/source/TimeSeriesMappingSource.java

@@ -23,7 +23,7 @@ public abstract class TimeSeriesMappingSource {
 
   private final TimeSeriesMappingFactory mappingFactory;
 
-  public TimeSeriesMappingSource() {
+  protected TimeSeriesMappingSource() {
     this.mappingFactory = new TimeSeriesMappingFactory();
   }
 

src/main/java/edu/ie3/datamodel/io/source/csv/CsvIdCoordinateSource.java

@@ -34,7 +34,7 @@ public class CsvIdCoordinateSource implements IdCoordinateSource {
 
   protected static final Logger log = LoggerFactory.getLogger(CsvIdCoordinateSource.class);
 
-  private static final String coordinateIdMapping = "coordinate id mapping";
+  private static final String COORDINATE_ID_MAPPING = "coordinate id mapping";
 
   /** Mapping in both ways (id -> coordinate) and (coordinate -> id) have to be unique */
   private final Map<Integer, Point> idToCoordinate;
@@ -167,15 +167,15 @@ protected Stream<Map<String, String>> buildStreamWithFieldsToAttributesMap() {
           fieldToValues -> fieldToValues.get(factory.getIdField());
       Set<Map<String, String>> withDistinctCoordinateId =
           dataSource.distinctRowsWithLog(
-              allRows, idExtractor, coordinateIdMapping, "coordinate id");
+              allRows, idExtractor, COORDINATE_ID_MAPPING, "coordinate id");
       Function<Map<String, String>, String> coordinateExtractor =
           fieldToValues ->
               fieldToValues
                   .get(factory.getLatField())
                   .concat(fieldToValues.get(factory.getLonField()));
       return dataSource
           .distinctRowsWithLog(
-              withDistinctCoordinateId, coordinateExtractor, coordinateIdMapping, "coordinate")
+              withDistinctCoordinateId, coordinateExtractor, COORDINATE_ID_MAPPING, "coordinate")
           .parallelStream();
     } catch (IOException e) {
       log.error("Cannot read the file for coordinate id to coordinate mapping.", e);

src/main/java/edu/ie3/datamodel/io/source/csv/CsvTimeSeriesSource.java

@@ -95,8 +95,7 @@ public CsvTimeSeriesSource(
     /* Read in the full time series */
     try {
       this.timeSeries =
-          buildIndividualTimeSeries(
-              timeSeriesUuid, filePath, fieldToValue -> this.createTimeBasedValue(fieldToValue));
+          buildIndividualTimeSeries(timeSeriesUuid, filePath, this::createTimeBasedValue);
     } catch (SourceException e) {
       throw new IllegalArgumentException(
           "Unable to obtain time series with UUID '"

src/main/java/edu/ie3/datamodel/io/source/sql/SqlDataSource.java

@@ -24,8 +24,6 @@ public class SqlDataSource implements DataSource {
 
   protected static final Logger log = LoggerFactory.getLogger(SqlDataSource.class);
 
-  private static final String errorSQL = "Error during execution of query {}";
-
   protected final SqlConnector connector;
   protected final DatabaseNamingStrategy databaseNamingStrategy;
   protected String schemaName;
@@ -164,7 +162,7 @@ protected Stream<Map<String, String>> executeQuery(String query, AddParams addPa
       ResultSet resultSet = ps.executeQuery();
       return connector.extractFieldMaps(resultSet).stream();
     } catch (SQLException e) {
-      log.error(errorSQL, query, e);
+      log.error("Error during execution of query {}", query, e);
     }
     return Stream.empty();
   }