Skip to content

Commit a140d70

Browse files
Merge remote-tracking branch 'origin/sh/#872-storage-documentation' into sh/#872-storage-documentation
2 parents 34212c5 + 26e3009 commit a140d70

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

src/test/groovy/edu/ie3/datamodel/io/source/csv/CsvTypeSourceTest.groovy

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -160,17 +160,6 @@ class CsvTypeSourceTest extends Specification implements CsvTestDataMeta {
160160
activePowerGradient == sptd.storageTypeInput.activePowerGradient
161161
eta == sptd.storageTypeInput.eta
162162
}
163-
def storageTypes = typeSource.storageTypes
164-
storageTypes.first().uuid == sptd.storageTypeInput.uuid
165-
storageTypes.first().id == sptd.storageTypeInput.id
166-
storageTypes.first().capex == sptd.storageTypeInput.capex
167-
storageTypes.first().opex == sptd.storageTypeInput.opex
168-
storageTypes.first().eStorage == sptd.storageTypeInput.eStorage
169-
storageTypes.first().sRated == sptd.storageTypeInput.sRated
170-
storageTypes.first().cosPhiRated == sptd.storageTypeInput.cosPhiRated
171-
storageTypes.first().pMax == sptd.storageTypeInput.pMax
172-
storageTypes.first().activePowerGradient == sptd.storageTypeInput.activePowerGradient
173-
storageTypes.first().eta == sptd.storageTypeInput.eta
174163
}
175164

176165
def "A CsvTypeSource should read and handle valid wec type file as expected"() {

src/test/groovy/edu/ie3/datamodel/utils/validation/SystemParticipantValidationUtilsTest.groovy

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -410,9 +410,7 @@ class SystemParticipantValidationUtilsTest extends Specification {
410410

411411
where:
412412
invalidStorageType || expectedException
413-
new StorageTypeInput(uuid, id, capex, opex, eStorage, sRated, cosPhiRated, pMax, cpRate, eta, -1) || new InvalidEntityException("Permissible amount of life cycles of the storage type must be zero or positive", invalidStorageType)
414413
new StorageTypeInput(uuid, id, capex, opex, eStorage, sRated, cosPhiRated, pMax, cpRate, Quantities.getQuantity(110, EFFICIENCY)) || new InvalidEntityException("Efficiency of the electrical converter of StorageTypeInput must be between 0% and 100%", invalidStorageType)
415-
new StorageTypeInput(uuid, id, capex, opex, eStorage, sRated, cosPhiRated, pMax, cpRate, eta, Quantities.getQuantity(-10, EFFICIENCY)) || new InvalidEntityException("Maximum permissible depth of discharge of StorageTypeInput must be between 0% and 100%", invalidStorageType)
416414
new StorageTypeInput(uuid, id, capex, opex, eStorage, sRated, cosPhiRated, Quantities.getQuantity(-15, ACTIVE_POWER_IN), Quantities.getQuantity(-100, ACTIVE_POWER_GRADIENT), eta) || new InvalidEntityException("The following quantities have to be zero or positive: -15 kW, -100 %/h, -10.5 h", invalidStorageType)
417415
new StorageTypeInput(uuid, id, capex, opex, Quantities.getQuantity(0, ENERGY_IN), sRated, cosPhiRated, pMax, cpRate, eta) || new InvalidEntityException("The following quantities have to be positive: 0 kWh", invalidStorageType)
418416
}

0 commit comments

Comments
 (0)