Skip to content

Commit ba5f2b3

Browse files
committed
Merge branch 'dev' into ms/#1128-adding-voltage-timeseries
# Conflicts: # src/test/resources/edu/ie3/datamodel/io/source/csv/_timeseries/time_series_mapping.csv # src/test/resources/edu/ie3/datamodel/io/source/sql/_timeseries/time_series_mapping.sql
2 parents f4a042a + 934600c commit ba5f2b3

File tree

7 files changed

+27
-23
lines changed

7 files changed

+27
-23
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1919
- Improving usage of streams on sql fetches [#827](https://github.com/ie3-institute/PowerSystemDataModel/issues/827)
2020
- Improving error message when using the outdated csv format [#1112](https://github.com/ie3-institute/PowerSystemDataModel/issues/1112)
2121
- Changed ThermalUnitValidation: Ensure that thermal boundaries of thermal house are not the same [#1186](https://github.com/ie3-institute/PowerSystemDataModel/issues/1186)
22+
- Converted `MappingEntry` into a normal class [#1087](https://github.com/ie3-institute/PowerSystemDataModel/issues/1087)
23+
- Renamed timeseries mapping `participant` column to `asset` [#1191](https://github.com/ie3-institute/PowerSystemDataModel/issues/1191)
2224

2325
## [5.1.0] - 2024-06-24
2426

src/main/java/edu/ie3/datamodel/io/factory/timeseries/TimeSeriesMappingFactory.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,16 +8,13 @@
88
import edu.ie3.datamodel.io.factory.EntityData;
99
import edu.ie3.datamodel.io.factory.EntityFactory;
1010
import edu.ie3.datamodel.io.source.TimeSeriesMappingSource;
11-
import java.util.Collections;
1211
import java.util.List;
1312
import java.util.Set;
1413
import java.util.UUID;
15-
import java.util.stream.Collectors;
16-
import java.util.stream.Stream;
1714

1815
public class TimeSeriesMappingFactory
1916
extends EntityFactory<TimeSeriesMappingSource.MappingEntry, EntityData> {
20-
private static final String PARTICIPANT = "participant";
17+
private static final String ASSET = "asset";
2118
private static final String TIME_SERIES = "timeSeries";
2219

2320
public TimeSeriesMappingFactory() {
@@ -26,14 +23,13 @@ public TimeSeriesMappingFactory() {
2623

2724
@Override
2825
protected List<Set<String>> getFields(Class<?> entityClass) {
29-
return Collections.singletonList(
30-
Stream.of(PARTICIPANT, TIME_SERIES).collect(Collectors.toSet()));
26+
return List.of(newSet(ASSET, TIME_SERIES));
3127
}
3228

3329
@Override
3430
protected TimeSeriesMappingSource.MappingEntry buildModel(EntityData data) {
35-
UUID participant = data.getUUID(PARTICIPANT);
31+
UUID asset = data.getUUID(ASSET);
3632
UUID timeSeries = data.getUUID(TIME_SERIES);
37-
return new TimeSeriesMappingSource.MappingEntry(participant, timeSeries);
33+
return new TimeSeriesMappingSource.MappingEntry(asset, timeSeries);
3834
}
3935
}

src/main/java/edu/ie3/datamodel/io/source/TimeSeriesMappingSource.java

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
import edu.ie3.datamodel.io.factory.EntityData;
1212
import edu.ie3.datamodel.io.factory.timeseries.TimeSeriesMappingFactory;
1313
import edu.ie3.datamodel.models.input.InputEntity;
14-
import edu.ie3.datamodel.models.input.system.SystemParticipantInput;
1514
import edu.ie3.datamodel.models.timeseries.TimeSeries;
1615
import edu.ie3.datamodel.utils.Try;
1716
import edu.ie3.datamodel.utils.Try.*;
@@ -47,7 +46,7 @@ public Map<UUID, UUID> getMapping() throws SourceException {
4746
.filter(Try::isSuccess)
4847
.map(t -> (Success<MappingEntry, FactoryException>) t)
4948
.map(Success::get)
50-
.collect(Collectors.toMap(MappingEntry::participant, MappingEntry::timeSeries));
49+
.collect(Collectors.toMap(MappingEntry::getAsset, MappingEntry::getTimeSeries));
5150
}
5251

5352
/**
@@ -80,12 +79,19 @@ private Try<MappingEntry, FactoryException> createMappingEntry(
8079

8180
// -=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-
8281

83-
/** Class to represent one entry within the participant to time series mapping */
84-
public record MappingEntry(UUID participant, UUID timeSeries) implements InputEntity {
82+
/** Class to represent one entry within the asset to time series mapping */
83+
public static class MappingEntry implements InputEntity {
84+
private final UUID asset;
85+
private final UUID timeSeries;
8586

86-
/** Returns the {@link UUID} of the {@link SystemParticipantInput}. */
87-
public UUID getParticipant() {
88-
return participant;
87+
public MappingEntry(UUID asset, UUID timeSeries) {
88+
this.asset = asset;
89+
this.timeSeries = timeSeries;
90+
}
91+
92+
/** Returns the {@link UUID} of the {@link edu.ie3.datamodel.models.input.AssetInput}. */
93+
public UUID getAsset() {
94+
return asset;
8995
}
9096

9197
/** Returns the {@link UUID} of the {@link TimeSeries}. */
@@ -97,17 +103,17 @@ public UUID getTimeSeries() {
97103
public boolean equals(Object o) {
98104
if (this == o) return true;
99105
if (!(o instanceof MappingEntry that)) return false;
100-
return participant.equals(that.participant) && timeSeries.equals(that.timeSeries);
106+
return asset.equals(that.asset) && timeSeries.equals(that.timeSeries);
101107
}
102108

103109
@Override
104110
public int hashCode() {
105-
return Objects.hash(participant, timeSeries);
111+
return Objects.hash(asset, timeSeries);
106112
}
107113

108114
@Override
109115
public String toString() {
110-
return "MappingEntry{" + "participant=" + participant + ", timeSeries=" + timeSeries + '}';
116+
return "MappingEntry{" + "asset=" + asset + ", timeSeries=" + timeSeries + '}';
111117
}
112118
}
113119
}

src/main/java/edu/ie3/datamodel/utils/validation/UniquenessValidationUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public class UniquenessValidationUtils extends ValidationUtils {
3333
protected static final FieldSetSupplier<CongestionResult> congestionResultFieldSupplier =
3434
entity -> Set.of(entity.getTime(), entity.getSubgrid());
3535
protected static final FieldSetSupplier<MappingEntry> mappingFieldSupplier =
36-
entity -> Set.of(entity.participant());
36+
entity -> Set.of(entity.getAsset());
3737
protected static final FieldSetSupplier<IdCoordinateInput> idCoordinateSupplier =
3838
entity -> Set.of(entity.id(), entity.point());
3939
protected static final FieldSetSupplier<TimeBasedValue<WeatherValue>> weatherValueFieldSupplier =

src/test/groovy/edu/ie3/datamodel/io/processor/input/InputEntityProcessorTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -630,7 +630,7 @@ class InputEntityProcessorTest extends Specification {
630630
def validResult = new TimeSeriesMappingSource.MappingEntry(UUID.fromString("7eb7b296-f4c4-4020-acf3-e865453b5dbd"), UUID.fromString("bc581c6c-3044-48a1-aea1-5b2cb1370356"))
631631

632632
Map expectedResults = [
633-
"participant": "7eb7b296-f4c4-4020-acf3-e865453b5dbd",
633+
"asset": "7eb7b296-f4c4-4020-acf3-e865453b5dbd",
634634
"timeSeries": "bc581c6c-3044-48a1-aea1-5b2cb1370356"
635635
]
636636

src/test/resources/edu/ie3/datamodel/io/source/csv/_timeseries/time_series_mapping.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
"participant";"time_series"
1+
"asset";"time_series"
22
"b86e95b0-e579-4a80-a534-37c7a470a409";"9185b8c1-86ba-4a16-8dea-5ac898e8caa5"
33
"c7ebcc6c-55fc-479b-aa6b-6fa82ccac6b8";"3fbfaa97-cff4-46d4-95ba-a95665e87c26"
44
"90a96daa-012b-4fea-82dc-24ba7a7ab81c";"3fbfaa97-cff4-46d4-95ba-a95665e87c26"

src/test/resources/edu/ie3/datamodel/io/source/sql/_timeseries/time_series_mapping.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
CREATE TABLE public.time_series_mapping
22
(
3-
participant uuid PRIMARY KEY,
3+
asset uuid PRIMARY KEY,
44
time_series uuid
55
)
66
WITHOUT OIDS
77
TABLESPACE pg_default;
88

99
INSERT INTO
10-
public.time_series_mapping (participant, time_series)
10+
public.time_series_mapping (asset, time_series)
1111
VALUES
1212
('b86e95b0-e579-4a80-a534-37c7a470a409', '9185b8c1-86ba-4a16-8dea-5ac898e8caa5'),
1313
('c7ebcc6c-55fc-479b-aa6b-6fa82ccac6b8', '3fbfaa97-cff4-46d4-95ba-a95665e87c26'),

0 commit comments

Comments
 (0)