Introduce a storage model for domestic hot water #1132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…umberInhabitants to ThermalHouse
danielfeismann
added
enhancement
…l' into df/#1131-psdm-update-for-tap-water-demand # Conflicts: # src/main/java/edu/ie3/datamodel/io/factory/input/CylindricalStorageInputFactory.java # src/main/java/edu/ie3/datamodel/models/input/thermal/CylindricalStorageInput.java # src/main/java/edu/ie3/datamodel/utils/validation/ThermalUnitValidationUtils.java # src/test/groovy/edu/ie3/datamodel/utils/validation/ThermalUnitValidationUtilsTest.groovy
…statistical data of average households
…-demand # Conflicts: # src/test/groovy/edu/ie3/datamodel/io/factory/input/CylindricalStorageInputFactoryTest.groovy
Member
Author
|
@sebastian-peter there is one test failing due to scaling. Return of copyBuilder scale looks fine, but these values are not taken into account when building the model. Do you have any idea where this is going wrong? |
danielfeismann
changed the title
staudtMarius
requested changes
Feb 24, 2025
Member
staudtMarius
left a comment
staudtMarius
left a comment
There was a problem hiding this comment.
Found some parts, that can be improved.
src/main/java/edu/ie3/datamodel/io/factory/input/CylindricalStorageInputFactory.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/io/factory/input/DomesticHotWaterStorageInputFactory.java
Show resolved
Hide resolved
src/main/java/edu/ie3/datamodel/models/input/thermal/CylindricalStorageInput.java
Outdated
Show resolved
Hide resolved
src/test/groovy/edu/ie3/datamodel/models/input/container/ThermalGridTest.groovy
Show resolved
Hide resolved
src/test/resources/edu/ie3/datamodel/io/source/csv/_participants/cylindrical_storage_input.csv
Show resolved
Hide resolved
src/test/resources/edu/ie3/datamodel/io/source/csv/_thermal/cylindrical_storage_input.csv
Show resolved
Hide resolved
3 tasks
staudtMarius
requested changes
Feb 25, 2025
Member
staudtMarius
left a comment
staudtMarius
left a comment
There was a problem hiding this comment.
Almost there, just one more issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1257
merge first: