-
Notifications
You must be signed in to change notification settings - Fork 7
Use ValidationUtils for ThermalGrids #1118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # CHANGELOG.md
staudtMarius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a small question regarding this PR.
src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala
Outdated
Show resolved
Hide resolved
staudtMarius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The import in the HpAgentFundamentals is no longer necessary.
src/main/scala/edu/ie3/simona/agent/participant/hp/HpAgentFundamentals.scala
Outdated
Show resolved
Hide resolved
staudtMarius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resolves #1117
at least for thermalGrids and their assets.
requires: