From 0509546533afcc3380792f79396a7af6896d84a1 Mon Sep 17 00:00:00 2001 From: lichriszhang Date: Sun, 26 Apr 2026 12:28:04 +0800 Subject: [PATCH] fix(web): restore empty-query skill discovery --- web/src/shared/hooks/skill-query-helpers.test.ts | 8 ++++---- web/src/shared/hooks/skill-query-helpers.ts | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/web/src/shared/hooks/skill-query-helpers.test.ts b/web/src/shared/hooks/skill-query-helpers.test.ts index 7381037a2..aaf18c893 100644 --- a/web/src/shared/hooks/skill-query-helpers.test.ts +++ b/web/src/shared/hooks/skill-query-helpers.test.ts @@ -17,16 +17,16 @@ describe('buildSkillSearchUrl', () => { expect(buildSkillSearchUrl({})).toBe('/api/web/skills') }) - it('keeps an empty q parameter when the search query is an empty string', () => { - expect(buildSkillSearchUrl({ q: '' })).toBe('/api/web/skills?q=') + it('omits q when the search query is an empty string', () => { + expect(buildSkillSearchUrl({ q: '' })).toBe('/api/web/skills') }) - it('normalizes whitespace-only queries to an empty q parameter', () => { + it('omits q when the normalized query is empty after trimming', () => { expect(buildSkillSearchUrl({ q: ' ', sort: 'relevance', page: 0, - })).toBe('/api/web/skills?q=&sort=relevance&page=0') + })).toBe('/api/web/skills?sort=relevance&page=0') }) }) diff --git a/web/src/shared/hooks/skill-query-helpers.ts b/web/src/shared/hooks/skill-query-helpers.ts index 24a9d7453..147d7a520 100644 --- a/web/src/shared/hooks/skill-query-helpers.ts +++ b/web/src/shared/hooks/skill-query-helpers.ts @@ -6,7 +6,7 @@ export function buildSkillSearchUrl(params: SearchParams) { const queryParams = new URLSearchParams() const normalizedQuery = normalizeSearchQuery(params.q ?? '') - if (params.q !== undefined) { + if (normalizedQuery) { queryParams.append('q', normalizedQuery) }