From f2f0f8a1d6a8890e1f6404d621308a9bc7840405 Mon Sep 17 00:00:00 2001 From: Frederick Vollbrecht <39002042+vollbrecht-work@users.noreply.github.com> Date: Sun, 31 Aug 2025 17:41:43 +0200 Subject: [PATCH] JPRO-183 fix window resize issues around all propertie description controller This contains only the hotfix part of https://github.com/ikmdev/komet/pull/688. --- .../AddFullyQualifiedNameController.java | 11 +- .../properties/AddOtherNameController.java | 11 +- .../EditDescriptionFormController.java | 12 +- .../EditFullyQualifiedNameController.java | 9 +- .../properties/add-fully-qualified-name.fxml | 213 ++++++------ .../mvvm/view/properties/add-other-name.fxml | 145 ++++---- .../properties/edit-fully-qualified-name.fxml | 77 +++-- .../view/properties/edit-other-name-form.fxml | 312 ++++++++++-------- 8 files changed, 438 insertions(+), 352 deletions(-) diff --git a/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/AddFullyQualifiedNameController.java b/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/AddFullyQualifiedNameController.java index a2b35f6e0..2f0e548e8 100644 --- a/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/AddFullyQualifiedNameController.java +++ b/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/AddFullyQualifiedNameController.java @@ -55,16 +55,19 @@ public class AddFullyQualifiedNameController extends AbstractBasicController { private Label addFqnTitleLabel; @FXML - private ComboBox moduleComboBox; + private TextField fullyQualifiedNameTextField; @FXML - private TextField fullyQualifiedNameTextField; + private ComboBox typeDisplayComboBox; + + @FXML + private ComboBox caseSignificanceComboBox; @FXML private ComboBox statusComboBox; @FXML - private ComboBox caseSignificanceComboBox; + private ComboBox moduleComboBox; @FXML private ComboBox languageComboBox; @@ -253,7 +256,7 @@ private void saveFullQualifiedName(ActionEvent actionEvent) { } @FXML - public void cancel() { + public void handleCancelButtonEvent() { close(); } diff --git a/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/AddOtherNameController.java b/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/AddOtherNameController.java index ef7008e35..d80d2f7f6 100644 --- a/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/AddOtherNameController.java +++ b/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/AddOtherNameController.java @@ -56,16 +56,19 @@ public class AddOtherNameController extends AbstractBasicController { private Label addOtherNameTitleLabel; @FXML - private ComboBox moduleComboBox; + private TextField otherNameTextField; @FXML - private TextField otherNameTextField; + private ComboBox typeDisplayComboBox; + + @FXML + private ComboBox caseSignificanceComboBox; @FXML private ComboBox statusComboBox; @FXML - private ComboBox caseSignificanceComboBox; + private ComboBox moduleComboBox; @FXML private ComboBox languageComboBox; @@ -263,7 +266,7 @@ public void clearView() { } @FXML - public void cancel() { + public void handleCancelButtonEvent() { close(); } diff --git a/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/EditDescriptionFormController.java b/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/EditDescriptionFormController.java index f2d08ff25..3f23286d0 100644 --- a/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/EditDescriptionFormController.java +++ b/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/EditDescriptionFormController.java @@ -88,16 +88,16 @@ public class EditDescriptionFormController implements BasicController { private TextField otherNameTextField; @FXML - private ComboBox comboBox; + private ComboBox typeDisplayComboBox; @FXML - private ComboBox moduleComboBox; + private ComboBox caseSignificanceComboBox; @FXML private ComboBox statusComboBox; @FXML - private ComboBox caseSignificanceComboBox; + private ComboBox moduleComboBox; @FXML private ComboBox languageComboBox; @@ -106,13 +106,13 @@ public class EditDescriptionFormController implements BasicController { private Label editDescriptionTitleLabel; @FXML - private Label dialect1; + private Label dialect1Label; @FXML - private Label dialect2; + private Label dialect2Label; @FXML - private Label dialect3; + private Label dialect3Label; @FXML private ComboBox dialectComboBox1; diff --git a/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/EditFullyQualifiedNameController.java b/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/EditFullyQualifiedNameController.java index eecffb98f..052bbf031 100644 --- a/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/EditFullyQualifiedNameController.java +++ b/kview/src/main/java/dev/ikm/komet/kview/mvvm/view/properties/EditFullyQualifiedNameController.java @@ -68,6 +68,9 @@ public class EditFullyQualifiedNameController implements BasicController { @FXML private TextField fqnText; + @FXML + private ComboBox typeDisplayComboBox; + @FXML private ComboBox moduleComboBox; @@ -81,13 +84,13 @@ public class EditFullyQualifiedNameController implements BasicController { private ComboBox languageComboBox; @FXML - private Label dialect1; + private Label dialect1Label; @FXML - private Label dialect2; + private Label dialect2Label; @FXML - private Label dialect3; + private Label dialect3Label; @FXML private ComboBox dialectComboBox1; diff --git a/kview/src/main/resources/dev/ikm/komet/kview/mvvm/view/properties/add-fully-qualified-name.fxml b/kview/src/main/resources/dev/ikm/komet/kview/mvvm/view/properties/add-fully-qualified-name.fxml index 1d08f6fc5..c7a8e7758 100644 --- a/kview/src/main/resources/dev/ikm/komet/kview/mvvm/view/properties/add-fully-qualified-name.fxml +++ b/kview/src/main/resources/dev/ikm/komet/kview/mvvm/view/properties/add-fully-qualified-name.fxml @@ -14,102 +14,117 @@ - - - - - - - - - - - - - - - - - - -