Skip to content

Commit be06228

Browse files
authored
Merge pull request #19 from nipe0324/require-ruby-3.0.0-or-higher
Require Ruby 3.0.0 or higher
2 parents ea78c89 + 4fe390d commit be06228

File tree

6 files changed

+11
-15
lines changed

6 files changed

+11
-15
lines changed

.github/workflows/rspec.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ jobs:
1111
- uses: actions/checkout@v3
1212
- uses: ruby/setup-ruby@v1
1313
with:
14-
ruby-version: '2.3.1'
14+
ruby-version: '3.0.0'
1515
bundler-cache: true
1616
- run: gem install bundler -v '< 2.0'
1717
- run: bundle install

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
## Unreleased
22

33
- Migrate CI/CD platform from Travis CI to GitHub Actions
4+
- Requires Ruby 3.0.0 or higher
45

56
## v1.3.5
67

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ Qiita API v2 client library and CLI tool, written in Ruby.
77

88
## Install
99

10-
Note: requires Ruby 2.0.0 or higher.
10+
Note: requires Ruby 3.0.0 or higher.
1111

1212
```bash
1313
gem install qiita

lib/qiita/client.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
require "uri"
21
require "qiita/resource_based_methods"
32
require "qiita/version"
43

@@ -152,7 +151,7 @@ def process(request_method, path, params, headers)
152151
Qiita::Response.new(
153152
connection.send(
154153
request_method,
155-
URI.escape(path),
154+
path,
156155
params,
157156
headers,
158157
)

qiita.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Gem::Specification.new do |spec|
2222
spec.add_dependency "rainbow"
2323
spec.add_dependency "rouge"
2424
spec.add_dependency "slop", "< 4.0.0"
25-
spec.add_development_dependency "bundler", "~> 1.6"
25+
spec.add_development_dependency "bundler", "~> 2.2"
2626
spec.add_development_dependency "json_schema"
2727
spec.add_development_dependency "pry"
2828
spec.add_development_dependency "rake"

spec/qiita/client_spec.rb

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def stub_api_request
4949
end
5050

5151
let(:client) do
52-
described_class.new(options)
52+
described_class.new(**options)
5353
end
5454

5555
let(:options) do
@@ -116,11 +116,7 @@ def stub_api_request
116116

117117
describe ".new" do
118118
subject do
119-
described_class.new(*arguments)
120-
end
121-
122-
let(:arguments) do
123-
[options]
119+
described_class.new(**options)
124120
end
125121

126122
let(:options) do
@@ -133,9 +129,9 @@ def stub_api_request
133129
end
134130
end
135131

136-
context "without any arguments" do
137-
let(:arguments) do
138-
[]
132+
context "without any options" do
133+
let(:options) do
134+
{}
139135
end
140136
include_examples "returns a Qiita::Client"
141137
end
@@ -281,7 +277,7 @@ def stub_api_request
281277
end
282278

283279
let(:requested_url) do
284-
"https://#{requested_host}#{URI.escape(path)}"
280+
"https://#{requested_host}#{CGI.escape(path)}"
285281
end
286282

287283
it "sends request with escaped path" do

0 commit comments

Comments
 (0)