From 34380a75e85588121c55d316e96c40b3805d15c6 Mon Sep 17 00:00:00 2001 From: Paul DelRe Date: Fri, 4 Oct 2019 08:41:15 -0400 Subject: [PATCH 1/2] Remove contradictory "optional" Guideline --- CONTRIBUTE.md | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/CONTRIBUTE.md b/CONTRIBUTE.md index d9348f1..c3ee147 100644 --- a/CONTRIBUTE.md +++ b/CONTRIBUTE.md @@ -26,18 +26,17 @@ We appreciate any efforts to help us writing this library. You can contribute in In order for your pull requests to get accepted we hold all the code to the following criteria: * PSR-1/PSR-2 compliant -* Do not use left hand conditions such as false == $something +* Do not use left hand conditions such as `false == $something`, rather use `$something === false` * New features need to be documented * Breaking changes should be well highlighted and explained in the PR * Only short-array syntax should be used for arrays -* Use regular string concatenation for single-variable strings, and sprintf for multi-variable strings +* Use regular string concatenation for single-variable strings, and `sprintf` for multi-variable strings * Do not align variable assignments The following is optional but encouraged: * Code should be documented * Code should be unit tested -* Do not write conditions like false === $something, rather $something === false. ## Special thanks @@ -47,4 +46,4 @@ We would like to thank the following people for helping to make this library pos * LeaseWeb Technologies * Paul Dix * Sean Beckett -* CentaurWarchief \ No newline at end of file +* CentaurWarchief From 45143f818380188dde82e8d98325a000704baa27 Mon Sep 17 00:00:00 2001 From: Paul DelRe Date: Fri, 4 Oct 2019 08:43:33 -0400 Subject: [PATCH 2/2] Use consistent conditional --- CONTRIBUTE.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTE.md b/CONTRIBUTE.md index c3ee147..420613d 100644 --- a/CONTRIBUTE.md +++ b/CONTRIBUTE.md @@ -26,7 +26,7 @@ We appreciate any efforts to help us writing this library. You can contribute in In order for your pull requests to get accepted we hold all the code to the following criteria: * PSR-1/PSR-2 compliant -* Do not use left hand conditions such as `false == $something`, rather use `$something === false` +* Do not use left hand conditions such as `false === $something`, rather use `$something === false` * New features need to be documented * Breaking changes should be well highlighted and explained in the PR * Only short-array syntax should be used for arrays