Skip to content

Conversation

@hermannakos
Copy link
Collaborator

Implements support for Studio embed videos to open in immersive view with "Open in Detail View" buttons. This provides better video viewing experience for Studio content embedded in pages and assignments.

Changes:

  • Detect Studio embed URLs (thumbnail_embed and learn_embed types)
  • Detect Studio media URLs (media_attachments_iframe)
  • Transform embed URLs to immersive view format with required parameters
  • Add "Open in Detail View" buttons below Studio iframes
  • Route immersive view URLs to InternalWebviewFragment without LTI auth
  • Extract and pass video titles to immersive view

Known limitation:

  • Buttons inside iframes cannot be intercepted due to WebView cross-origin isolation. Users must use the "Open in Detail View" button below the iframe.
  • Working with web team on postMessage solution for better UX.

Test plan:

  • Verify Studio embed iframes show "Open in Detail View" button
  • Verify button navigates to immersive view in InternalWebviewFragment
  • Verify video title displays correctly in immersive view
  • Verify standard media uploads continue to work with Expand button

refs: MBL-19552
affects: Student
release note: none

🤖 Generated with Claude Code

Implements support for Studio embed videos to open in immersive view with
"Open in Detail View" buttons. This provides better video viewing experience
for Studio content embedded in pages and assignments.

Changes:
- Detect Studio embed URLs (thumbnail_embed and learn_embed types)
- Detect Studio media URLs (media_attachments_iframe)
- Transform embed URLs to immersive view format with required parameters
- Add "Open in Detail View" buttons below Studio iframes
- Route immersive view URLs to InternalWebviewFragment without LTI auth
- Extract and pass video titles to immersive view

Known limitation:
- Buttons inside iframes cannot be intercepted due to WebView cross-origin
  isolation. Users must use the "Open in Detail View" button below the iframe.
- Working with web team on postMessage solution for better UX.

Test plan:
- Verify Studio embed iframes show "Open in Detail View" button
- Verify button navigates to immersive view in InternalWebviewFragment
- Verify video title displays correctly in immersive view
- Verify standard media uploads continue to work with Expand button

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions
Copy link

📊 Code Coverage Report

⚠️ Student

  • PR Coverage: 42.50%
  • Master Coverage: 42.61%
  • Delta: -0.10%

✅ Teacher

  • PR Coverage: 25.44%
  • Master Coverage: 25.44%
  • Delta: +0.00%

✅ Pandautils

  • PR Coverage: 22.59%
  • Master Coverage: 22.59%
  • Delta: +0.00%

📈 Overall Average

  • PR Coverage: 30.18%
  • Master Coverage: 30.21%
  • Delta: -0.03%

@github-actions
Copy link

Student Install Page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants