From 5c7776e88cde7892eff6afa878ebc11ffbe605ee Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Mon, 8 Dec 2025 17:38:54 -0800 Subject: [PATCH 1/5] Support clang-20 shared library build --- cmake/options.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/cmake/options.cmake b/cmake/options.cmake index 2f9dd416a..4b5284217 100644 --- a/cmake/options.cmake +++ b/cmake/options.cmake @@ -174,6 +174,7 @@ target_compile_options( -Wno-gnu-zero-variadic-macro-arguments -Wno-address-of-packed-member # When calling Intel(R) MKL GEMMs with BFloat16/Float16 -Wno-parentheses # GCC in CI has issues without it + -Wno-deprecated-literal-operator ) From 6d451dba69688ca08b29d0b2c0ce331a1c8678c9 Mon Sep 17 00:00:00 2001 From: ethanglaser <42726565+ethanglaser@users.noreply.github.com> Date: Wed, 10 Dec 2025 11:25:57 -0800 Subject: [PATCH 2/5] Add comment --- cmake/options.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/options.cmake b/cmake/options.cmake index 4b5284217..df97ba3b4 100644 --- a/cmake/options.cmake +++ b/cmake/options.cmake @@ -174,7 +174,7 @@ target_compile_options( -Wno-gnu-zero-variadic-macro-arguments -Wno-address-of-packed-member # When calling Intel(R) MKL GEMMs with BFloat16/Float16 -Wno-parentheses # GCC in CI has issues without it - -Wno-deprecated-literal-operator + -Wno-deprecated-literal-operator # TODO: remove once eve releases with clang-20 support ) From 66c6f3e9b3076ce23c9c200e0dc6aa8cfe48d4f8 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Wed, 10 Dec 2025 11:37:51 -0800 Subject: [PATCH 3/5] Move to gcc specific --- cmake/options.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/options.cmake b/cmake/options.cmake index df97ba3b4..78429f11d 100644 --- a/cmake/options.cmake +++ b/cmake/options.cmake @@ -174,7 +174,6 @@ target_compile_options( -Wno-gnu-zero-variadic-macro-arguments -Wno-address-of-packed-member # When calling Intel(R) MKL GEMMs with BFloat16/Float16 -Wno-parentheses # GCC in CI has issues without it - -Wno-deprecated-literal-operator # TODO: remove once eve releases with clang-20 support ) @@ -198,6 +197,7 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") INTERFACE -fconcepts-diagnostics-depth=10 -ftemplate-backtrace-limit=0 + -Wno-deprecated-literal-operator # TODO: remove once eve releases with clang-20 support ) if (CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 12.0) From 0f5f5a8e5320b71cb040c3e82b3de712f5324c07 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Wed, 10 Dec 2025 11:38:34 -0800 Subject: [PATCH 4/5] fix indentation --- cmake/options.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmake/options.cmake b/cmake/options.cmake index 78429f11d..a11698366 100644 --- a/cmake/options.cmake +++ b/cmake/options.cmake @@ -197,7 +197,7 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") INTERFACE -fconcepts-diagnostics-depth=10 -ftemplate-backtrace-limit=0 - -Wno-deprecated-literal-operator # TODO: remove once eve releases with clang-20 support + -Wno-deprecated-literal-operator # TODO: remove once eve releases with clang-20 support ) if (CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 12.0) From 17259e428e95623d1a3b4dae179c27440856a1f8 Mon Sep 17 00:00:00 2001 From: ethanglaser Date: Wed, 10 Dec 2025 12:48:32 -0800 Subject: [PATCH 5/5] Add flag specifically for clang20 --- cmake/options.cmake | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmake/options.cmake b/cmake/options.cmake index a11698366..9067faccb 100644 --- a/cmake/options.cmake +++ b/cmake/options.cmake @@ -188,6 +188,10 @@ endif() # Fix Clang complaining about the sized delete operator. if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" OR CMAKE_CXX_COMPILER_ID STREQUAL "IntelLLVM") target_compile_options(${SVS_LIB} INTERFACE -fsized-deallocation) + # TODO: remove once eve releases with clang-20 support + if (CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 20.0) + target_compile_options(svs_compile_options INTERFACE -Wno-deprecated-literal-operator) + endif() endif() # Provide better diagnostics for broken templates. @@ -197,7 +201,6 @@ if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") INTERFACE -fconcepts-diagnostics-depth=10 -ftemplate-backtrace-limit=0 - -Wno-deprecated-literal-operator # TODO: remove once eve releases with clang-20 support ) if (CMAKE_CXX_COMPILER_VERSION GREATER_EQUAL 12.0)