Read text ssh #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR modifies the CustomPath class to improve SSH path operations and text reading capabilities. The changes enable proper handling of path division operations for Python versions prior to 3.12 and refactor the read_text method to use streaming instead of blocking command execution.
Key Changes:
- Added
__truediv__and__rtruediv__methods for Python <3.12 to preserve_ownerattribute during path operations - Refactored
read_textto usestart_processwith streaming output instead of blockingexecute_command
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mchromin
approved these changes
Nov 25, 2025
mfd_connect/pathlib/path.py
Outdated
| else: | ||
| def __truediv__(self, key): | ||
| try: | ||
| child = super(CustomPath, self).__truediv__(key) |
Contributor
There was a problem hiding this comment.
Suggested change
| child = super(CustomPath, self).__truediv__(key) | |
| child = super().__truediv__(key) |
python2 syntax
mfd_connect/pathlib/path.py
Outdated
|
|
||
| def __rtruediv__(self, key): | ||
| try: | ||
| child = super(CustomPath, self).__rtruediv__(key) |
Contributor
There was a problem hiding this comment.
Suggested change
| child = super(CustomPath, self).__rtruediv__(key) | |
| child = super().__rtruediv__(key) |
as above
Signed-off-by: Baczek, Arkadiusz <arkadiusz.baczek@intel.com>
hanging due to large output Signed-off-by: Baczek, Arkadiusz <arkadiusz.baczek@intel.com>
abaczek
force-pushed
the
read_text_ssh
branch
from
fed1ec8 to
ed35875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to the
CustomPathclass inmfd_connect/pathlib/path.py, focusing on compatibility and robustness. The main changes include adding custom division operator methods for path joining and updating the file reading method to use a more reliable process-based approach.Compatibility enhancements:
__truediv__and__rtruediv__methods toCustomPathto support path joining with proper owner propagation, improving compatibility with older Python versions.Robustness improvements:
read_textmethod to use a process iterator for reading file contents, which enhances reliability when handling large files or streaming output.