Skip to content

fix the extra <p> in the linkout component #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 2, 2025
Merged

fix the extra <p> in the linkout component #62

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63c5878
fix the extra <p> in the linkout component
JonathanMatthey Nov 28, 2025
1813570
rm linkout class
JonathanMatthey Dec 2, 2025
a4121f3
pnpm format
JonathanMatthey Dec 2, 2025
956f95a
rm class
JonathanMatthey Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 6 additions & 12 deletions src/components/LinkOut.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,13 @@
---
const { href, withIcon = true } = Astro.props
let slotContent = await Astro.slots.render('default')
// Remove wrapping <p> tags that MDX adds
slotContent = slotContent.replace(/^<p>(.*)<\/p>$/s, '$1').trim()
---

{
withIcon ? (
<a href={href} target="_blank" rel="noopener noreferrer">
<slot />
<span class="icon" />
</a>
) : (
<a href={href} target="_blank" rel="noopener noreferrer">
<slot />
</a>
)
}
<a href={href} target="_blank" rel="noopener noreferrer"
><Fragment set:html={slotContent} />{withIcon && <span class="icon" />}</a
>

<style>
.icon {
Expand Down