fix: switch off lower(COLUMN_NAME) decoration on String equality check (#186)

* fix: switch off lower(COLUMN_NAME) decoration on String equality check

* fix: add unit tests with EQ case matching

Author: igdianov

graphql-jpa-query-schema/src/main/java/com/introproventures/graphql/jpa/query/schema/impl/JpaPredicateBuilder.java

@@ -105,13 +105,12 @@ protected Predicate addOrNull(Path<?> root, Predicate p) {
      * @return
      */
     protected Predicate getStringPredicate(Path<String> root, PredicateFilter filter) {
-        Expression<String> fieldValue;
-
         // list or arrays only for in and not in, between and not between
         Predicate arrayValuePredicate = mayBeArrayValuePredicate(root, filter);
 
         if(arrayValuePredicate == null) {
             String compareValue = filter.getValue().toString();
+            Expression<String> fieldValue = root;
 
             if (filter.getCriterias().contains(PredicateFilter.Criteria.IN)) {
                 CriteriaBuilder.In<Object> in = cb.in(root);
@@ -120,15 +119,7 @@ protected Predicate getStringPredicate(Path<String> root, PredicateFilter filter
             if (filter.getCriterias().contains(PredicateFilter.Criteria.NIN)) {
                 return cb.not(root.in(compareValue));
             }
-
-            if (filter.getCriterias().contains(PredicateFilter.Criteria.CASE)) {
-                fieldValue = root;
-            }
-            else {
-                fieldValue = cb.lower(root);
-                compareValue = compareValue.toLowerCase();
-            }
-
+            
             if (filter.getCriterias().contains(PredicateFilter.Criteria.EQ)) {
                 return cb.equal(fieldValue, compareValue);
             } 

graphql-jpa-query-schema/src/test/java/com/introproventures/graphql/jpa/query/schema/GraphQLExecutorTests.java

@@ -27,13 +27,6 @@
 
 import javax.persistence.EntityManager;
 
-import com.introproventures.graphql.jpa.query.schema.impl.GraphQLJpaExecutor;
-import com.introproventures.graphql.jpa.query.schema.impl.GraphQLJpaSchemaBuilder;
-import graphql.ErrorType;
-import graphql.ExecutionResult;
-import graphql.GraphQLError;
-import graphql.validation.ValidationError;
-import graphql.validation.ValidationErrorType;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -52,6 +45,7 @@
 import graphql.ExecutionResult;
 import graphql.GraphQLError;
 import graphql.validation.ValidationError;
+import graphql.validation.ValidationErrorType;
 
 
 @RunWith(SpringRunner.class)
@@ -1448,5 +1442,35 @@ public void queryForTransientMethodAnnotatedWithGraphQLIgnoreShouldFail() {
                 .extracting("validationErrorType", "queryPath")
                 .containsOnly(tuple(ValidationErrorType.FieldUndefined, list("Books", "select", "authorName")));
     }
+    
+    @Test
+    public void queryWithEQNotMatchingCase() {
+        //given:
+        String query = "query { Books ( where: { title: {EQ: \"War And Peace\"}}) { select { id title} } }";
+
+        String expected = "{Books={select=[]}}";
+
+        //when:
+        Object result = executor.execute(query).getData();
+
+        //then:
+        assertThat(result.toString()).isEqualTo(expected);
+    }
+    
+    @Test
+    public void queryWithEQMatchingCase() {
+        //given:
+        String query = "query { Books ( where: { title: {EQ: \"War and Peace\"}}) { select { id title} } }";
+
+        String expected = "{Books={select=[" +
+                "{id=2, title=War and Peace}" +
+                "]}}";
+
+        //when:
+        Object result = executor.execute(query).getData();
+
+        //then:
+        assertThat(result.toString()).isEqualTo(expected);
+    }        
 
 }