refactor(config): set environment variables for minifyjs, minifycss, aot, and optimizejs

Author: danbucholtz

config/webpack.config.js

@@ -14,6 +14,55 @@ var ionicWebpackFactory = require(process.env.IONIC_WEBPACK_FACTORY);
 var ModuleConcatPlugin = require('webpack/lib/optimize/ModuleConcatenationPlugin');
 var PurifyPlugin = require('@angular-devkit/build-optimizer').PurifyPlugin;
 
+var optimizedProdLoaders = [
+  {
+    test: /\.json$/,
+    loader: 'json-loader'
+  },
+  {
+    test: /\.js$/,
+    loader: [
+      {
+        loader: process.env.IONIC_CACHE_LOADER
+      },
+
+      {
+        loader: '@angular-devkit/build-optimizer/webpack-loader',
+        options: {
+          sourceMap: true
+        }
+      },
+    ]
+  },
+  {
+    test: /\.ts$/,
+    loader: [
+      {
+        loader: process.env.IONIC_CACHE_LOADER
+      },
+
+      {
+        loader: '@angular-devkit/build-optimizer/webpack-loader',
+        options: {
+          sourceMap: true
+        }
+      },
+
+      {
+        loader: process.env.IONIC_WEBPACK_LOADER
+      }
+    ]
+  }
+];
+
+function getProdLoaders() {
+  if (process.env.IONIC_OPTIMIZE_JS === 'true') {
+    console.log('using prod loaders');
+    return optimizedProdLoaders;
+  }
+  console.log('using dev loaders');
+  return devConfig.module.loaders;
+}
 
 var devConfig = {
   entry: process.env.IONIC_APP_ENTRY_POINT,
@@ -73,46 +122,7 @@ var prodConfig = {
   },
 
   module: {
-    loaders: [
-      {
-        test: /\.json$/,
-        loader: 'json-loader'
-      },
-      {
-        test: /\.js$/,
-        loader: [
-          {
-            loader: process.env.IONIC_CACHE_LOADER
-          },
-
-          {
-            loader: '@angular-devkit/build-optimizer/webpack-loader',
-            options: {
-              sourceMap: true
-            }
-          },
-        ]
-      },
-      {
-        test: /\.ts$/,
-        loader: [
-          {
-            loader: process.env.IONIC_CACHE_LOADER
-          },
-
-          {
-            loader: '@angular-devkit/build-optimizer/webpack-loader',
-            options: {
-              sourceMap: true
-            }
-          },
-
-          {
-            loader: process.env.IONIC_WEBPACK_LOADER
-          }
-        ]
-      }
-    ]
+    loaders: getProdLoaders()
   },
 
   plugins: [

src/util/config.spec.ts

@@ -67,6 +67,11 @@ describe('config', () => {
       expect(context.optimizeJs).toEqual(false);
       expect(fakeConfig[Constants.ENV_VAR_IONIC_ENV]).toEqual(Constants.ENV_VAR_DEV);
 
+      expect(fakeConfig[Constants.ENV_VAR_IONIC_AOT]).toEqual('false');
+      expect(fakeConfig[Constants.ENV_VAR_IONIC_MINIFY_JS]).toEqual('false');
+      expect(fakeConfig[Constants.ENV_VAR_IONIC_MINIFY_CSS]).toEqual('false');
+      expect(fakeConfig[Constants.ENV_VAR_IONIC_OPTIMIZE_JS]).toEqual('false');
+
       expect(context.rootDir).toEqual(process.cwd());
       expect(context.tmpDir).toEqual(join(process.cwd(), Constants.TMP_DIR));
       expect(context.srcDir).toEqual(join(process.cwd(), Constants.SRC_DIR));
@@ -180,6 +185,10 @@ describe('config', () => {
       expect(context.runMinifyJs).toEqual(true);
       expect(context.runMinifyCss).toEqual(true);
       expect(context.optimizeJs).toEqual(true);
+      expect(fakeConfig[Constants.ENV_VAR_IONIC_AOT]).toEqual('true');
+      expect(fakeConfig[Constants.ENV_VAR_IONIC_MINIFY_JS]).toEqual('true');
+      expect(fakeConfig[Constants.ENV_VAR_IONIC_MINIFY_CSS]).toEqual('true');
+      expect(fakeConfig[Constants.ENV_VAR_IONIC_OPTIMIZE_JS]).toEqual('true');
       expect(fakeConfig[Constants.ENV_VAR_IONIC_ENV]).toEqual(Constants.ENV_VAR_PROD);
       expect(fakeConfig[Constants.ENV_VAR_GENERATE_SOURCE_MAP]).toBeFalsy();
     });

src/util/config.ts

@@ -62,6 +62,21 @@ export function generateContext(context?: BuildContext): BuildContext {
     context.isWatch = hasArg('--watch');
   }
 
+  setProcessEnvVar(Constants.ENV_VAR_IONIC_AOT, `${context.runAot}`);
+  Logger.debug(`${Constants.ENV_VAR_IONIC_AOT} set to ${context.runAot}`);
+
+  setProcessEnvVar(Constants.ENV_VAR_IONIC_MINIFY_JS, `${context.runMinifyJs}`);
+  Logger.debug(`${Constants.ENV_VAR_IONIC_MINIFY_JS} set to ${context.runMinifyJs}`);
+
+  setProcessEnvVar(Constants.ENV_VAR_IONIC_MINIFY_CSS, `${context.runMinifyCss}`);
+  Logger.debug(`${Constants.ENV_VAR_IONIC_MINIFY_CSS} set to ${context.runMinifyCss}`);
+
+  setProcessEnvVar(Constants.ENV_VAR_IONIC_OPTIMIZE_JS, `${context.optimizeJs}`);
+  Logger.debug(`${Constants.ENV_VAR_IONIC_OPTIMIZE_JS} set to ${context.optimizeJs}`);
+
+  setProcessEnvVar(Constants.ENV_VAR_IONIC_MINIFY_JS, `${context.runMinifyJs}`);
+  Logger.debug(`${Constants.ENV_VAR_IONIC_MINIFY_JS} set to ${context.runMinifyJs}`);
+
   context.rootDir = resolve(context.rootDir || getConfigValue(context, '--rootDir', null, Constants.ENV_VAR_ROOT_DIR, Constants.ENV_VAR_ROOT_DIR.toLowerCase(), processCwd));
   setProcessEnvVar(Constants.ENV_VAR_ROOT_DIR, context.rootDir);
   Logger.debug(`rootDir set to ${context.rootDir}`);

src/util/constants.ts

@@ -27,6 +27,12 @@ export const CORDOVA = 'cordova';
 export const ENV_VAR_PROD = 'prod';
 export const ENV_VAR_DEV = 'dev';
 export const ENV_VAR_IONIC_ENV = 'IONIC_ENV';
+
+export const ENV_VAR_IONIC_AOT = 'IONIC_AOT';
+export const ENV_VAR_IONIC_MINIFY_JS = 'IONIC_MINIFY_JS';
+export const ENV_VAR_IONIC_MINIFY_CSS = 'IONIC_MINIFY_CSS';
+export const ENV_VAR_IONIC_OPTIMIZE_JS = 'IONIC_OPTIMIZE_JS';
+
 export const ENV_VAR_ROOT_DIR = 'IONIC_ROOT_DIR';
 export const ENV_VAR_SRC_DIR = 'IONIC_SRC_DIR';
 export const ENV_VAR_DEEPLINKS_DIR = 'IONIC_DEEPLINKS_DIR';