feature(lint): ability to disable lint (used in Ionic E2E tests)

Author: danbucholtz

src/build.spec.ts

@@ -48,6 +48,8 @@ describe('build', () => {
       runAot: true
     };
 
+    const getBooleanPropertyValueSpy = spyOn(helpers, helpers.getBooleanPropertyValue.name).and.returnValue(true);
+
     return build.build(context).then(() => {
       expect(helpers.readFileAsync).toHaveBeenCalled();
       expect(copy.copy).toHaveBeenCalled();
@@ -57,9 +59,11 @@ describe('build', () => {
       expect(sass.sass).toHaveBeenCalled();
       expect(minify.minifyCss).toHaveBeenCalled();
       expect(lint.lint).toHaveBeenCalled();
+      expect(getBooleanPropertyValueSpy.calls.first().args[0]).toEqual(Constants.ENV_ENABLE_LINT);
 
       expect(transpile.transpile).not.toHaveBeenCalled();
     }).catch(err => {
+      console.log('err: ', err.message);
       expect(true).toEqual(false);
     });
   });
@@ -73,13 +77,45 @@ describe('build', () => {
       runAot: false
     };
 
+    const getBooleanPropertyValueSpy = spyOn(helpers, helpers.getBooleanPropertyValue.name).and.returnValue(true);
+
     return build.build(context).then(() => {
       expect(helpers.readFileAsync).toHaveBeenCalled();
       expect(copy.copy).toHaveBeenCalled();
       expect(transpile.transpile).toHaveBeenCalled();
       expect(bundle.bundle).toHaveBeenCalled();
       expect(sass.sass).toHaveBeenCalled();
       expect(lint.lint).toHaveBeenCalled();
+      expect(getBooleanPropertyValueSpy.calls.first().args[0]).toEqual(Constants.ENV_ENABLE_LINT);
+      expect(postprocess.postprocess).toHaveBeenCalled();
+      expect(preprocess.preprocess).toHaveBeenCalled();
+      expect(ngc.ngc).not.toHaveBeenCalled();
+      expect(minify.minifyJs).not.toHaveBeenCalled();
+      expect(minify.minifyCss).not.toHaveBeenCalled();
+    }).catch(err => {
+      expect(true).toEqual(false);
+    });
+  });
+
+  it('should skip lint', () => {
+    let context: BuildContext = {
+      isProd: false,
+      optimizeJs: false,
+      runMinifyJs: false,
+      runMinifyCss: false,
+      runAot: false
+    };
+
+    const getBooleanPropertyValueSpy = spyOn(helpers, helpers.getBooleanPropertyValue.name).and.returnValue(false);
+
+    return build.build(context).then(() => {
+      expect(helpers.readFileAsync).toHaveBeenCalled();
+      expect(copy.copy).toHaveBeenCalled();
+      expect(transpile.transpile).toHaveBeenCalled();
+      expect(bundle.bundle).toHaveBeenCalled();
+      expect(sass.sass).toHaveBeenCalled();
+      expect(lint.lint).not.toHaveBeenCalled();
+      expect(getBooleanPropertyValueSpy.calls.first().args[0]).toEqual(Constants.ENV_ENABLE_LINT);
       expect(postprocess.postprocess).toHaveBeenCalled();
       expect(preprocess.preprocess).toHaveBeenCalled();
       expect(ngc.ngc).not.toHaveBeenCalled();

src/build.ts

@@ -126,11 +126,13 @@ function buildProject(context: BuildContext) {
       return postprocess(context);
     })
     .then(() => {
-      // kick off the tslint after everything else
-      // nothing needs to wait on its completion unless bailing on lint error is enabled
-      const result = lint(context);
-      if (getBooleanPropertyValue(Constants.ENV_BAIL_ON_LINT_ERROR)) {
-        return result;
+      if (getBooleanPropertyValue(Constants.ENV_ENABLE_LINT)) {
+        // kick off the tslint after everything else
+        // nothing needs to wait on its completion unless bailing on lint error is enabled
+        const result = lint(context);
+        if (getBooleanPropertyValue(Constants.ENV_BAIL_ON_LINT_ERROR)) {
+          return result;
+        }
       }
     })
     .catch(err => {
@@ -183,7 +185,9 @@ export function buildUpdate(changedFiles: ChangedFile[], context: BuildContext)
         if (requiresLintUpdate) {
           // a ts file changed, so let's lint it too, however
           // this task should run as an after thought
-          lintUpdate(changedFiles, context);
+          if (getBooleanPropertyValue(Constants.ENV_ENABLE_LINT)) {
+            lintUpdate(changedFiles, context);
+          }
         }
 
         logger.finish('green', true);

src/util/constants.ts

@@ -50,6 +50,8 @@ export const ENV_OPTIMIZATION_LOADER = 'IONIC_OPTIMIZATION_LOADER';
 export const ENV_AOT_WRITE_TO_DISK = 'IONIC_AOT_WRITE_TO_DISK';
 export const ENV_BAIL_ON_LINT_ERROR = 'IONIC_BAIL_ON_LINT_ERROR';
 export const ENV_BUILD_TO_ES5 = 'IONIC_BUILD_TO_ES5';
+export const ENV_ENABLE_LINT = 'IONIC_ENABLE_LINT';
+export const ENV_DISABLE_LOGGING = 'IONIC_DISABLE_LOGGING';
 
 export const ENV_PRINT_ORIGINAL_DEPENDENCY_TREE = 'IONIC_PRINT_ORIGINAL_DEPENDENCY_TREE';
 export const ENV_PRINT_MODIFIED_DEPENDENCY_TREE = 'IONIC_PRINT_MODIFIED_DEPENDENCY_TREE';