refactor(serve): add if statement around error logging, fix tests

add if statement around error logging, fix tests

Author: danbucholtz

src/serve.spec.ts

@@ -13,6 +13,7 @@ import * as network from './util/network';
 describe('test serve', () => {
   let configResults: ServeConfig;
   let context: BuildContext;
+  let openSpy: jasmine.Spy;
 
   beforeEach(() => {
     context = {
@@ -43,7 +44,7 @@ describe('test serve', () => {
     spyOn(liveReloadServer, 'createLiveReloadServer');
     spyOn(httpServer, 'createHttpServer');
     spyOn(watch, 'watch').and.returnValue(Promise.resolve());
-    spyOn(open, 'default');
+    openSpy = spyOn(open, 'default');
   });
 
   it('should work with no args on a happy path', () => {
@@ -52,7 +53,8 @@ describe('test serve', () => {
       expect(notificationServer.createNotificationServer).toHaveBeenCalledWith(configResults);
       expect(liveReloadServer.createLiveReloadServer).toHaveBeenCalledWith(configResults);
       expect(httpServer.createHttpServer).toHaveBeenCalledWith(configResults);
-      expect(open.default).toHaveBeenCalledWith('http://localhost:8100', null);
+      expect(openSpy.calls.mostRecent().args[0]).toEqual('http://localhost:8100');
+      expect(openSpy.calls.mostRecent().args[1]).toEqual(null);
     });
   });
 
@@ -65,7 +67,8 @@ describe('test serve', () => {
       expect(notificationServer.createNotificationServer).toHaveBeenCalledWith(configResults);
       expect(liveReloadServer.createLiveReloadServer).toHaveBeenCalledWith(configResults);
       expect(httpServer.createHttpServer).toHaveBeenCalledWith(configResults);
-      expect(open.default).toHaveBeenCalledWith('http://localhost:8100?ionicplatform=android', null);
+      expect(openSpy.calls.mostRecent().args[0]).toEqual('http://localhost:8100?ionicplatform=android');
+      expect(openSpy.calls.mostRecent().args[1]).toEqual(null);
     });
   });
 
@@ -103,7 +106,8 @@ describe('test serve', () => {
       expect(notificationServer.createNotificationServer).toHaveBeenCalledWith(configResults);
       expect(liveReloadServer.createLiveReloadServer).toHaveBeenCalledWith(configResults);
       expect(httpServer.createHttpServer).toHaveBeenCalledWith(configResults);
-      expect(open.default).toHaveBeenCalledWith('http://127.0.0.1:8101/ionic-lab', 'safari');
+      expect(openSpy.calls.mostRecent().args[0]).toEqual('http://127.0.0.1:8101/ionic-lab');
+      expect(openSpy.calls.mostRecent().args[1]).toEqual('safari');
     });
   });
 });

src/serve.ts

@@ -77,8 +77,10 @@ function onReady(config: ServeConfig, context: BuildContext) {
       .concat(platformOption(context) ? ['?ionicplatform=', platformOption(context)] : []);
 
     open(openOptions.join(''), browserToLaunch(context), (error: Error) => {
-      const errorMessage = error && error.message ? error.message : error.toString();
-      Logger.warn(`Failed to open the browser: ${errorMessage}`);
+      if (error) {
+        const errorMessage = error && error.message ? error.message : error.toString();
+        Logger.warn(`Failed to open the browser: ${errorMessage}`);
+      }
     });
   }
   Logger.info(`dev server running: ${config.hostBaseUrl}/`, 'green', true);