fix(appflow): allow download of packages built from branches with in the name. CT-434 (#4622)

Luke W. McCullough · web-flow · commit 0054fd51706c · 2020-12-10T10:47:06.000-05:00
diff --git a/packages/@ionic/cli/src/commands/package/build.ts b/packages/@ionic/cli/src/commands/package/build.ts
@@ -387,7 +387,7 @@ This can be used only together with build type ${input('release')} for Android a
     if (!filename) {
       req.on('response', res => {
         const contentDisposition = res.header['content-disposition'];
-        filename = contentDisposition ? contentDisposition.split('=')[1] : 'output.bin';
+        filename = contentDisposition ? contentDisposition.split('=')[1].replace(/([/?<>*|\"])/g, '_') : 'output.bin';
       });
     }
 

Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,7 @@ This can be used only together with build type ${input('release')} for Android a`
`387`	`387`	`if (!filename) {`
`388`	`388`	`req.on('response', res => {`
`389`	`389`	`const contentDisposition = res.header['content-disposition'];`
`390`		`- filename = contentDisposition ? contentDisposition.split('=')[1] : 'output.bin';`
	`390`	`+ filename = contentDisposition ? contentDisposition.split('=')[1].replace(/([/?<>*\|\"])/g, '_') : 'output.bin';`
`391`	`391`	`});`
`392`	`392`	`}`
`393`	`393`