Issue-174: Mock iota client in integration tests #235

ezienecker · 2020-10-11T17:07:08Z

Description of change

Mock iota client in integration test

Type of change

Choose a type of change, and delete any options that are not relevant.

Enhancement (a non-breaking change which adds functionality)

How the change has been tested

Running the tests.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes, and delete any items that are not.

My code follows the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation -> not needed
I have added tests using ginkgo that prove my fix is effective or that my feature works -> not needed
New and existing unit tests pass locally with my changes

… client

…UE-229-removal-of-checkConsistency ISSUE-229: Remove check consistency code, test and related docs

kwek20 · 2020-10-11T17:23:26Z

Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 6
- Added 56
           

Complexity increasing per file
==============================
- jota/src/test/java/org/iota/jota/IotaMultiSigTest.java  1
         

Clones added
============
- jota/src/test/java/org/iota/jota/IotaAPITest.java  2
- jota/src/test/java/org/iota/jota/IotaMultiSigTest.java  2

See the complete overview on Codacy

kwek20 · 2020-10-11T17:23:26Z

jota/src/test/java/org/iota/jota/utils/InputValidatorTest.java

    @Test
    public void shouldIsArrayOfTrytes() {
-        assertEquals(InputValidator.isArrayOfTrytes(new String[]{TEST_TRYTES, TEST_TRYTES}), true);
+        assertTrue(InputValidator.isArrayOfTrytes(new String[]{TEST_TRYTES, TEST_TRYTES}));


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:27Z

jota/src/test/java/org/iota/jota/IotaAPITest.java


+        List<Transaction> transactionObjectsByAddresses = iotaAPIMock.findTransactionObjectsByAddresses(TEST_ADDRESSES);
+
+        assertNotNull(transactionObjectsByAddresses);


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:29Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+        FindTransactionResponse transactionsByApproves =
+                iotaAPIMock.findTransactionsByApprovees(TEST_ADDRESS_WITHOUT_CHECKSUM);
+
+        assertNotNull(transactionsByApproves.getHashes());


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:29Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+
+        GetNodeInfoResponse nodeInfo = iotaAPIMock.getNodeInfo();
+
+        assertNotNull(nodeInfo.getAppVersion());


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:30Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+        when(iotaAPIMock.findTransactions(addresses, tags, approves, bundles)).thenReturn(new FindTransactionResponse());
+
+        FindTransactionResponse transactionResponse = iotaAPIMock.findTransactions(addresses, tags, approves, approves);
+        assertNotNull(transactionResponse);


Codacy found an issue: JUnit assertions should include a message

jota/src/main/java/org/iota/jota/model/Transaction.java

kwek20 · 2020-10-11T17:23:32Z

jota/src/test/java/org/iota/jota/IotaAPITest.java

+        when(iotaAPIMock.getAddressesUnchecked(addressRequest)).thenReturn(newAddressResponse);
+
+        GetNewAddressResponse addressResponse = iotaAPIMock.getAddressesUnchecked(addressRequest);
+        assertEquals(TEST_ADDRESS_WITH_CHECKSUM_SECURITY_LEVEL_2, addressResponse.getAddresses().get(0));


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:33Z

jota/src/test/java/org/iota/jota/IotaLocalPoWTest.java

        for (int i = 0; i < TEST_TRYTES_VALUE_TRANSFER.length; i++) {
-            assertEquals(new Transaction(localResponse.getTrytes()[i]).getValue(),
-                    new Transaction(remoteResponse.getTrytes()[i]).getValue());
+            assertEquals(new Transaction.Builder().buildWithTrytes(localResponse.getTrytes()[i]).getValue(),


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:34Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+        FindTransactionResponse transactionsByAddresses =
+                iotaAPIMock.findTransactionsByAddresses(TEST_ADDRESS_WITHOUT_CHECKSUM);
+
+        assertNotNull(transactionsByAddresses.getHashes());


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:35Z

jota/src/test/java/org/iota/jota/IotaAPITest.java

+        when(iotaAPIMock.getAddressesUnchecked(addressRequest)).thenReturn(newAddressResponse);
+
+        GetNewAddressResponse res1 = iotaAPIMock.getAddressesUnchecked(addressRequest);
+        assertEquals(TEST_ADDRESS_WITH_CHECKSUM_SECURITY_LEVEL_3, res1.getAddresses().get(0));


Codacy found an issue: JUnit assertions should include a message

jota/src/main/java/org/iota/jota/model/Transaction.java

kwek20 · 2020-10-11T17:23:37Z

jota/src/test/java/org/iota/jota/IotaAPITest.java

-        final GetNewAddressResponse res3 = iotaAPI.getAddressesUnchecked(thirdAddressRequest);
-        assertEquals(TEST_ADDRESS_WITH_CHECKSUM_SECURITY_LEVEL_3, res3.getAddresses().get(0));
+        GetNewAddressResponse addressResponse = iotaAPIMock.getAddressesUnchecked(addressRequest);
+        assertEquals(TEST_ADDRESS_WITH_CHECKSUM_SECURITY_LEVEL_1, addressResponse.getAddresses().get(0));


Codacy found an issue: JUnit assertions should include a message

jota/src/main/java/org/iota/jota/model/Transaction.java

kwek20 · 2020-10-11T17:23:38Z

jota/src/main/java/org/iota/jota/IotaAccount.java

-            } if (!transfer.getMessage().equals("")) {
+
+            }
+            if (!transfer.getMessage().equals("")) {


Codacy found an issue: Avoid empty if statements

jota/src/main/java/org/iota/jota/model/Transaction.java

kwek20 · 2020-10-11T17:23:40Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+        when(balancesResponseMock.getDuration()).thenReturn(0L);
+
+        assertThat(balancesResponse.getReferences(), IsNull.notNullValue());
+        assertThat(balancesResponse.getBalances(), IsNull.notNullValue());


Codacy found an issue: JUnit assertions should include a message

jota/src/main/java/org/iota/jota/model/Transaction.java

kwek20 · 2020-10-11T17:23:42Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+        assertThat(balancesResponse.getReferences(), IsNull.notNullValue());
+        assertThat(balancesResponse.getBalances(), IsNull.notNullValue());
+        assertThat(balancesResponse.getMilestoneIndex(), IsNull.notNullValue());
+        assertThat(balancesResponse.getDuration(), IsNull.notNullValue());


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:43Z

jota/src/test/java/org/iota/jota/IotaAPITest.java

-        assertThat("Error on getInputs should have thrown", res.getInputs(), IsNull.notNullValue());
+        GetBalancesAndFormatResponse inputs = iotaAPIMock.getInputs(TEST_SEED1, 2, 0, 10, 0);
+
+        assertNotNull(inputs);


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:44Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+        GetNodeInfoResponse nodeInfo = iotaAPIMock.getNodeInfo();
+
+        assertNotNull(nodeInfo.getAppVersion());
+        assertNotNull(nodeInfo.getAppName());


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:45Z

jota/src/test/java/org/iota/jota/IotaAPITest.java

+
+        GetAccountDataResponse accountData = iotaAPIMock.getAccountData(TEST_SEED3, 2, 0, true, 0, true, 0, 10, true, 0);
+
+        assertNotNull(accountData);


Codacy found an issue: JUnit assertions should include a message

kwek20 · 2020-10-11T17:23:46Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+        assertNotNull(nodeInfo.getAppName());
+        assertNotNull(nodeInfo.getJreVersion());
+        assertNotNull(nodeInfo.getLatestMilestone());
+        assertNotNull(nodeInfo.getLatestSolidSubtangleMilestone());


Codacy found an issue: JUnit assertions should include a message

jota/src/main/java/org/iota/jota/model/Transaction.java

kwek20 · 2020-10-11T17:23:47Z

jota/src/test/java/org/iota/jota/IotaCoreApiTest.java

+        when(balancesResponseMock.getBalances()).thenReturn(new String[]{});
+        when(balancesResponseMock.getDuration()).thenReturn(0L);
+
+        assertThat(balancesResponse.getReferences(), IsNull.notNullValue());


Codacy found an issue: JUnit assertions should include a message

jota/src/main/java/org/iota/jota/model/Transaction.java

ezienecker · 2020-10-16T09:46:11Z

I am not sure if the checks regarding the assertions are useful. On the one hand this contradicts the Clean Code concept by saying that the methods should be named in a way that they make a statement about what the method does (What is tested?). On the other hand I doubt the quality of the messages.

kwek20 · 2020-10-16T19:11:05Z

Yea thanks for the Codacy fixes you did, I'm honestly just surprised it decided to work suddenly :)
Ill test and review in the weekend as I'm currently a bit busy with Streams, but this is a great help! Especially when we move forward with chrysalis 2.0. Could you solve the conflicts though? If not, ill do it later :)

… client

…:ManuZiD/iota-java into feature/ISSUE-174-mock-integration-tests

ezienecker · 2020-10-19T18:36:05Z

@kwek20 now it should be fine

kwek20 · 2020-10-19T19:39:17Z

@ezienecker Thanks for the ping 🙏 On it!

Manu Zi and others added 9 commits October 2, 2020 09:14

ISSUE-229: Remove check consistency code, test and related docs

e69c2ed

ISSUE-174: Start migrate integration test to use mock instead of real…

42f590b

… client

ISSUE-174: Refactor transaction class and fix some minor code smells

6f94c40

ISSUE-174: Mock iota client for IotaLocalPoWTest

f7146d3

ISSUE-174: Mock iota client for IotaLocalPoWTest

3131cff

ISSUE-174: Fix some minor smells

dce52b5

ISSUE-174: Mock iota client for IotaCoreApiTest

592985a

ISSUE-229: Implement review remarks

f12cc97

Merge pull request iotaledger-archive#234 from ezienecker/feature/ISS…

a047fa4

…UE-229-removal-of-checkConsistency ISSUE-229: Remove check consistency code, test and related docs

kwek20 reviewed Oct 11, 2020

View reviewed changes

jota/src/main/java/org/iota/jota/model/Transaction.java Show resolved Hide resolved

kwek20 reviewed Oct 11, 2020

View reviewed changes

jota/src/main/java/org/iota/jota/model/Transaction.java Show resolved Hide resolved

kwek20 reviewed Oct 11, 2020

View reviewed changes

jota/src/main/java/org/iota/jota/model/Transaction.java Show resolved Hide resolved

kwek20 reviewed Oct 11, 2020

View reviewed changes

jota/src/main/java/org/iota/jota/model/Transaction.java Show resolved Hide resolved

kwek20 reviewed Oct 11, 2020

View reviewed changes

jota/src/main/java/org/iota/jota/model/Transaction.java Show resolved Hide resolved

kwek20 reviewed Oct 11, 2020

View reviewed changes

jota/src/main/java/org/iota/jota/model/Transaction.java Show resolved Hide resolved

kwek20 reviewed Oct 11, 2020

View reviewed changes

jota/src/main/java/org/iota/jota/model/Transaction.java Show resolved Hide resolved

ISSUE-174: Add documentation to transaction builder methods

0210476

Manu Zi added 4 commits October 16, 2020 11:53

ISSUE-174: Add messages for assertions in test

33d8c4c

ISSUE-174: Add more method documentation

d4594ee

ISSUE-174: Codacy happiness

1743aa4

ISSUE-174: Document assertions in IotaCoreApiTest

4db4236

Manu Zi added 13 commits October 19, 2020 20:21

ISSUE-174: Start migrate integration test to use mock instead of real…

60db27e

… client

ISSUE-174: Refactor transaction class and fix some minor code smells

de25d79

ISSUE-174: Mock iota client for IotaLocalPoWTest

a140e63

ISSUE-174: Mock iota client for IotaLocalPoWTest

bf48a59

ISSUE-174: Fix some minor smells

f77e029

ISSUE-174: Mock iota client for IotaCoreApiTest

94137d0

ISSUE-174: Add documentation to transaction builder methods

17eebcb

ISSUE-174: Add messages for assertions in test

902d027

ISSUE-174: Add more method documentation

bac1bd6

ISSUE-174: Codacy happiness

4ad4e20

ISSUE-174: Document assertions in IotaCoreApiTest

a783b16

Resolve conflicts

ae04ef1

Merge branch 'feature/ISSUE-174-mock-integration-tests' of github.com…

a8738a3

…:ManuZiD/iota-java into feature/ISSUE-174-mock-integration-tests

Removed checkconsistency

27d6ba0


		List<Transaction> transactionObjectsByAddresses = iotaAPIMock.findTransactionObjectsByAddresses(TEST_ADDRESSES);

		assertNotNull(transactionObjectsByAddresses);


		GetNodeInfoResponse nodeInfo = iotaAPIMock.getNodeInfo();

		assertNotNull(nodeInfo.getAppVersion());


		GetAccountDataResponse accountData = iotaAPIMock.getAccountData(TEST_SEED3, 2, 0, true, 0, true, 0, 10, true, 0);

		assertNotNull(accountData);

Issue-174: Mock iota client in integration tests #235

Are you sure you want to change the base?

Issue-174: Mock iota client in integration tests #235

Uh oh!

Conversation

ezienecker commented Oct 11, 2020

Description of change

Type of change

How the change has been tested

Change checklist

Uh oh!

kwek20 commented Oct 11, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ezienecker commented Oct 16, 2020

Uh oh!

kwek20 commented Oct 16, 2020

Uh oh!

ezienecker commented Oct 19, 2020

Uh oh!

kwek20 commented Oct 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants