-
Notifications
You must be signed in to change notification settings - Fork 6
Description
The whole dict is a GeoJSON object.
Update after reading through the function definition: it's supposed to be a GeoJSON object, but I don't think it's a valid one, because it's missing the type attribute. I have the feeling this function was written by reverse engineering an example, by someone who wasn't familiar with GeoJSON or shapely.
I don't think that person was me, but I also recognize something I did that no longer makes sense to me: I don't think it should be necessary to convert everything to MultiPolygons in line 187.
Since this PR extracts logic to make it reusable in multiple maprooms, this seems like an appropriate time to clean it up/generalize it. But I would rather do the cleanup myself than explain how I think it should be done and then have you find out it doesn't work. So we can either have me contribute to this PR, or we can merge it and I'll follow up with another one.
Originally posted by @aaron-kaplan in #528 (comment)