[#771] Use named loggers instead of directly calling logging

Author: stevenvdb

irods/auth/__init__.py

@@ -17,6 +17,9 @@
 _NoneType = type(None)
 
 
+_logger = logging.getLogger(__name__)
+
+
 class AuthStorage:
     """A class that facilitates flexible means of password storage.
 
@@ -166,7 +169,7 @@ def __init__(self, connection, scheme):
         self.scheme = scheme
 
     def call(self, next_operation, request):
-        logging.debug("next operation = %r", next_operation)
+        _logger.debug("next operation = %r", next_operation)
         old_func = func = next_operation
         # One level of indirection should be sufficient to get a callable method.
         if not callable(func):
@@ -175,7 +178,7 @@ def call(self, next_operation, request):
         if not callable(func):
             raise RuntimeError("client request contains no callable 'next_operation'")
         resp = func(request)
-        logging.debug("resp = %r", resp)
+        _logger.debug("resp = %r", resp)
         return resp
 
     def authenticate_client(
@@ -202,4 +205,4 @@ def authenticate_client(
                 )
             to_send = resp
 
-        logging.debug("fully authenticated")
+        _logger.debug("fully authenticated")

irods/manager/data_object_manager.py

@@ -404,7 +404,7 @@ def chksum(self, path, **options):
                 # We'll get a response in the client to help qualify or elaborate on the error thrown.
                 if msg_retn:
                     response = msg_retn[0]
-                logging.warning("Exception checksumming data object %r - %r", path, exc)
+                logger.warning("Exception checksumming data object %r - %r", path, exc)
             if "response" in locals():
                 try:
                     results = response.get_main_message(

irods/path/__init__.py

@@ -7,6 +7,9 @@
 import os
 
 
+_logger = logging.getLogger(__name__)
+
+
 class iRODSPath(str):
     """A subclass of the Python string that normalizes iRODS logical paths."""
 
@@ -49,7 +52,7 @@ def __new__(cls, *elem_list, **kw):
         """
         absolute_ = kw.pop("absolute", True)
         if kw:
-            logging.warning("These iRODSPath options have no effect: %r", kw.items())
+            _logger.warning("These iRODSPath options have no effect: %r", kw.items())
         normalized = _normalize_iRODS_logical_path(elem_list, absolute_)
         obj = str.__new__(cls, normalized)
         return obj